From: Greg KH <gregkh@linuxfoundation.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Colin Cross <ccross@android.com>,
Android Kernel Team <kernel-team@android.com>
Subject: Re: [PATCH 08/13] android: persistent_ram: handle reserving and mapping memory
Date: Wed, 7 Mar 2012 17:46:10 -0800 [thread overview]
Message-ID: <20120308014610.GA2297@kroah.com> (raw)
In-Reply-To: <1331158573.2191.189.camel@work-vm>
On Wed, Mar 07, 2012 at 02:16:13PM -0800, John Stultz wrote:
> On Wed, 2012-03-07 at 14:08 -0800, Greg KH wrote:
> > On Wed, Mar 07, 2012 at 01:58:18PM -0800, John Stultz wrote:
> > > From: Colin Cross <ccross@android.com>
> > >
> > > Replace the ioremapped memory passed in from the drivers with
> > > a memblock_reserve and vmap. Adds a new function,
> > > persistent_ram_early_init, designed to be called from the machine
> > > init_early callback, that calls memblock_remove and saves the
> > > provided persistent ram area layout.
> > >
> > > Drivers only pass in their struct device * and ecc settings.
> > > Locating and mapping the memory is now handled entirely within
> > > persistent_ram.
> > >
> > > Also, convert ram_console to the new persistent_ram_init
> > > parameters that only take a struct device * and ecc settings.
> > >
> > > CC: Greg KH <gregkh@linuxfoundation.org>
> > > CC: Android Kernel Team <kernel-team@android.com>
> > > Change-Id: Ibc87ec27b70ed1c928eaa487503469e199973058
> > > Change-Id: I12b018381a2ed5965a8a4b0da40c3e640f92b6cf
> > > Signed-off-by: Colin Cross <ccross@android.com>
> > > [jstultz: Fix pr_info casting issues on 64bit, folded two
> > > patches as the build breaks if they are apart. Also replaced
> > > phys_to_page() w/ pfn_to_page(addr>>PAGE_SHIFT), as phys_to_page
> > > is only on a few arches.]
> >
> > Please put your comments above the signed-off-by area, it makes it
> > easier on tools that parse this area.
>
> I can change it, but this is how SubmittingPatches suggests it be done:
>
> Signed-off-by: Random J Developer <random@developer.example.org>
> [lucky@maintainer.example.org: struct foo moved from foo.c to foo.h]
> Signed-off-by: Lucky K Maintainer <lucky@maintainer.example.org>
Oops, you are right, nevermind then. But the change-id stuff needs to
still go.
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-08 1:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 21:58 [PATCH 00/13] staging: Android updates John Stultz
2012-03-07 21:58 ` [PATCH 01/13] android: lowmemorykiller: Fix warning on 64bit John Stultz
2012-03-07 22:04 ` Greg KH
2012-03-07 22:24 ` John Stultz
2012-03-07 21:58 ` [PATCH 02/13] android: ram_console: set CON_ANYTIME console flag John Stultz
2012-03-07 22:07 ` Greg KH
2012-03-07 21:58 ` [PATCH 03/13] android: ram_console: move footer strings John Stultz
2012-03-07 21:58 ` [PATCH 04/13] android: ram_console: drop early buffer support John Stultz
2012-03-07 21:58 ` [PATCH 05/13] android: ram_console: drop verbose ram_console support John Stultz
2012-03-07 21:58 ` [PATCH 06/13] android: ram_console: split out persistent ram John Stultz
2012-03-07 21:58 ` [PATCH 07/13] android: persistent_ram: refactor ecc support John Stultz
2012-03-07 22:21 ` Daniel Walker
2012-03-07 21:58 ` [PATCH 08/13] android: persistent_ram: handle reserving and mapping memory John Stultz
2012-03-07 22:08 ` Greg KH
2012-03-07 22:16 ` John Stultz
2012-03-08 1:46 ` Greg KH [this message]
2012-03-07 21:58 ` [PATCH 09/13] android: persistent_ram: make persistent_ram_write atomic John Stultz
2012-03-07 21:58 ` [PATCH 10/13] android: persistent_ram: add notrace to persistent_ram_write John Stultz
2012-03-07 21:58 ` [PATCH 11/13] android: persistent_trace: ftrace into persistent_ram John Stultz
2012-03-07 22:10 ` Greg KH
2012-03-07 22:40 ` John Stultz
2012-03-07 21:58 ` [PATCH 12/13] android: staging: ram_console: fix crash in ram_console_late_init John Stultz
2012-03-07 21:58 ` [PATCH 13/13] android: ram_console: honor dmesg_restrict John Stultz
2012-03-07 22:10 ` Greg KH
2012-03-07 22:11 ` [PATCH 00/13] staging: Android updates Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308014610.GA2297@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ccross@android.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox