From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756931Ab2CHLgU (ORCPT ); Thu, 8 Mar 2012 06:36:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753846Ab2CHLgT (ORCPT ); Thu, 8 Mar 2012 06:36:19 -0500 Date: Thu, 8 Mar 2012 11:36:07 +0000 From: "Daniel P. Berrange" To: Avi Kivity Cc: Wen Congyang , kvm list , qemu-devel , "linux-kernel@vger.kernel.org" , KAMEZAWA Hiroyuki , Jan Kiszka , Gleb Natapov Subject: Re: [RESEND][PATCH 2/2 v3] deal with guest panicked event Message-ID: <20120308113607.GC25529@redhat.com> Reply-To: "Daniel P. Berrange" References: <4F58664D.1070800@cn.fujitsu.com> <4F5868C4.2090509@cn.fujitsu.com> <4F5886C4.7040100@cn.fujitsu.com> <4F5897F8.6090503@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4F5897F8.6090503@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2012 at 01:28:56PM +0200, Avi Kivity wrote: > On 03/08/2012 12:15 PM, Wen Congyang wrote: > > When the host knows the guest is panicked, it will set > > exit_reason to KVM_EXIT_GUEST_PANICKED. So if qemu receive > > this exit_reason, we can send a event to tell management > > application that the guest is panicked and set the guest > > status to RUN_STATE_PANICKED. > > > > Signed-off-by: Wen Congyang > > --- > > kvm-all.c | 5 +++++ > > monitor.c | 3 +++ > > monitor.h | 1 + > > qapi-schema.json | 2 +- > > qmp.c | 3 ++- > > vl.c | 1 + > > 6 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/kvm-all.c b/kvm-all.c > > index 77eadf6..b3c9a83 100644 > > --- a/kvm-all.c > > +++ b/kvm-all.c > > @@ -1290,6 +1290,11 @@ int kvm_cpu_exec(CPUState *env) > > (uint64_t)run->hw.hardware_exit_reason); > > ret = -1; > > break; > > + case KVM_EXIT_GUEST_PANICKED: > > + monitor_protocol_event(QEVENT_GUEST_PANICKED, NULL); > > + vm_stop(RUN_STATE_PANICKED); > > + ret = -1; > > + break; > > > > If the management application is not aware of this event, then it will > never resume the guest, so it will appear hung. Even if the mgmt app doesn't know about the QEVENT_GUEST_PANICKED, it should still see a QEVENT_STOP event emitted by vm_stop() surely ? So it will know the guest CPUs have been stopped, even if it isn't aware of the reason why, which seems fine to me. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|