From: Andrew Morton <akpm@linux-foundation.org>
To: Roland McGrath <roland@hack.frob.com>
Cc: Jason Baron <jbaron@redhat.com>,
torvalds@linux-foundation.org, avi@redhat.com,
cmetcalf@tilera.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v2] core dump: add VM_NODUMP, MADV_NODUMP, MADV_CLEAR_NODUMP
Date: Thu, 8 Mar 2012 15:05:05 -0800 [thread overview]
Message-ID: <20120308150505.c9c3d309.akpm@linux-foundation.org> (raw)
In-Reply-To: <20120308214417.328502C0C8@topped-with-meat.com>
On Thu, 8 Mar 2012 13:44:17 -0800 (PST)
Roland McGrath <roland@hack.frob.com> wrote:
> I'm vaguely dubious about the desireability of using this new feature.
> (I would hate to try to debug a qemu bug from a dump where half the
> interesting state was intentionally hidden from me.)
yup. But the dumpability is fully controllable by userspace: one can
easily envisage large vma's full of data which just isn't interesting
for a dump. Plus if you're a developer who is looking at a dump and
important data isn't there, you can often delete one line, rebuild and
run the test again.
> But I don't see
> any problem with the implementation.
>
> As to the interface, I think the bits are OK but it would be more
> in keeping with the existing MADV_* names to call the new values
> MADV_DONTDUMP and MADV_DODUMP.
Yup. I queued a patch to do that.
prev parent reply other threads:[~2012-03-08 23:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 21:29 [PATCH 0/2 v2] core dump: re-purpose VM_ALWAYSDUMP to user controlled VM_NODUMP Jason Baron
2012-03-08 21:29 ` [PATCH 1/2 v2] core dump: drop VM_ALWAYSDUMP flag Jason Baron
2012-03-08 21:38 ` Roland McGrath
2012-03-08 21:29 ` [PATCH 2/2 v2] core dump: add VM_NODUMP, MADV_NODUMP, MADV_CLEAR_NODUMP Jason Baron
2012-03-08 21:44 ` Roland McGrath
2012-03-08 23:05 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308150505.c9c3d309.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=cmetcalf@tilera.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@hack.frob.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox