From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757544Ab2CHPoZ (ORCPT ); Thu, 8 Mar 2012 10:44:25 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:47643 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756983Ab2CHPoT (ORCPT ); Thu, 8 Mar 2012 10:44:19 -0500 X-Sasl-enc: 2g3d0gB+XLdEaaY9UgginpFb+oF+TTm+5TA8n8cfICpn 1331221458 Date: Thu, 8 Mar 2012 07:44:17 -0800 From: Greg KH To: Jesse Barnes Cc: Matthew Garrett , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, stable@kernel.org Subject: Re: [PATCH] Ignore pre-1.1 ASPM quirking when ASPM is disabled Message-ID: <20120308154417.GA5907@kroah.com> References: <1331059309-4335-1-git-send-email-mjg@redhat.com> <20120307054859.GB7775@kroah.com> <20120307202553.50b6c91c@jbarnes-x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120307202553.50b6c91c@jbarnes-x220> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2012 at 08:25:53PM -0800, Jesse Barnes wrote: > On Tue, 6 Mar 2012 21:48:59 -0800 > Greg KH wrote: > > > On Tue, Mar 06, 2012 at 01:41:49PM -0500, Matthew Garrett wrote: > > > Right now we won't touch ASPM state if ASPM is disabled, except in > > > the case where we find a device that appears to be too old to > > > reliably support ASPM. Right now we'll clear it in that case, which > > > is almost certainly the wrong thing to do. The easiest way around > > > this is just to disable the blacklisting when ASPM is disabled. > > > > > > Signed-off-by: Matthew Garrett > > > Cc: stable@kernel.org > > > > That's if we want to get it right :) > > > > Anyway, Jesse, this needs to get into 3.3-final to prevent > > regressions... > > Any bz links to add to the changelog? I'll fix up the stable cc when I > commit... Not that I know of, there was an email thread about this when I released the 3.2.5 kernel that talked about the problems with it which caused this patch to be created. thanks, greg k-h