public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] regulator: Fix setting selector in tps6524x set_voltage function
@ 2012-03-08  2:02 Axel Lin
  2012-03-08 18:07 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-03-08  2:02 UTC (permalink / raw)
  To: linux-kernel; +Cc: Cyril Chemparathy, Liam Girdwood, Mark Brown

Don't assign the voltage to selector.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/tps6524x-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/tps6524x-regulator.c b/drivers/regulator/tps6524x-regulator.c
index 70b7b1f..2e94686 100644
--- a/drivers/regulator/tps6524x-regulator.c
+++ b/drivers/regulator/tps6524x-regulator.c
@@ -481,7 +481,7 @@ static int set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV,
 	if (i >= info->n_voltages)
 		i = info->n_voltages - 1;
 
-	*selector = info->voltages[i];
+	*selector = i;
 
 	return write_field(hw, &info->voltage, i);
 }
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] regulator: Fix setting selector in tps6524x set_voltage function
  2012-03-08  2:02 [PATCH] regulator: Fix setting selector in tps6524x set_voltage function Axel Lin
@ 2012-03-08 18:07 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2012-03-08 18:07 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Cyril Chemparathy, Liam Girdwood

[-- Attachment #1: Type: text/plain, Size: 116 bytes --]

On Thu, Mar 08, 2012 at 10:02:17AM +0800, Axel Lin wrote:
> Don't assign the voltage to selector.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-08 18:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08  2:02 [PATCH] regulator: Fix setting selector in tps6524x set_voltage function Axel Lin
2012-03-08 18:07 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox