From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757056Ab2CHSjw (ORCPT ); Thu, 8 Mar 2012 13:39:52 -0500 Received: from mail-gy0-f174.google.com ([209.85.160.174]:44060 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753986Ab2CHSju (ORCPT ); Thu, 8 Mar 2012 13:39:50 -0500 Date: Thu, 8 Mar 2012 10:39:45 -0800 From: Greg KH To: Colin Cross Cc: John Stultz , lkml , Android Kernel Team Subject: Re: [PATCH 05/11] android: ram_console: split out persistent ram Message-ID: <20120308183945.GA29197@kroah.com> References: <1331170478-30538-1-git-send-email-john.stultz@linaro.org> <1331170478-30538-6-git-send-email-john.stultz@linaro.org> <20120308024203.GA25842@kroah.com> <20120308173306.GA4456@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2012 at 10:24:11AM -0800, Colin Cross wrote: > On Thu, Mar 8, 2012 at 9:33 AM, Greg KH wrote: > > On Wed, Mar 07, 2012 at 07:06:42PM -0800, Colin Cross wrote: > >> On Wed, Mar 7, 2012 at 6:42 PM, Greg KH wrote: > >> > On Wed, Mar 07, 2012 at 05:34:32PM -0800, John Stultz wrote: > >> >> From: Colin Cross > >> >> > >> >> Split ram_console into two halves. > >> >> > >> >> persistent_ram is a set of apis that handle a block of memory > >> >> that does not get erased across a reboot.  It provides functions > >> >> to fill it as a single buffer or a ring buffer, and to extract > >> >> the old data after a reboot.  It handles ecc on the data to > >> >> correct bit errors introduced during reboot. > >> > > >> > That's a nice idea, but why are you rolling your own interface here and > >> > not using the built-in one that the kernel already provides?  Is there > >> > something lacking with what we have today that requires you to create > >> > something different?  If so, why not just modify the existing interface > >> > to make it work for you, that way the tools already created will work > >> > automatically, and you will not have problems later ripping this out and > >> > porting it to the in-kernel api. > >> > >> What interface are you referring to, pstore? > > > > Yes. > > > >> As I explained in the email John quoted to you, > > > > Wait, what email?  Did I miss a response here?  Have a message-id: I can > > search for? > > Message ID 1331160054.2191.202.camel@work-vm Odd, that message id never got to me :(