From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757582Ab2CHSpv (ORCPT ); Thu, 8 Mar 2012 13:45:51 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56192 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139Ab2CHSps (ORCPT ); Thu, 8 Mar 2012 13:45:48 -0500 X-Sasl-enc: 34WaeUUVsOwh+J05faYoUXThy5w6XV0c4yDKXPHfgJFo 1331232346 Date: Thu, 8 Mar 2012 10:45:45 -0800 From: Greg KH To: Olaf Hering Cc: davem@davemloft.net, netdev@vger.kernel.org, Haiyang Zhang , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org Subject: Re: [PATCH] net/hyperv: Advertise hv_netvsc instead of netvsc as driver name Message-ID: <20120308184545.GA1100@kroah.com> References: <1331147131-6660-1-git-send-email-haiyangz@microsoft.com> <20120307201746.GA20900@aepfle.de> <20120307204946.GA4413@kroah.com> <20120308061615.GA25237@aepfle.de> <20120308155219.GC5907@kroah.com> <20120308161221.GA31415@aepfle.de> <20120308174220.GB17192@kroah.com> <20120308183820.GA25015@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120308183820.GA25015@aepfle.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2012 at 07:38:20PM +0100, Olaf Hering wrote: > On Thu, Mar 08, Greg KH wrote: > > > On Thu, Mar 08, 2012 at 05:12:21PM +0100, Olaf Hering wrote: > > > On Thu, Mar 08, Greg KH wrote: > > > > > > > > hwinfo uses it to recognize a network interface (storage in case of > > > > > hv_storvsc). > > > > > > > > That tool should report the real module name, not rely on the name to > > > > match based on the structure, if you really care about the real module > > > > name. > > > > > > Its about the driver symlink, not the module name. > > > > > > I think most, if not all, (relevant) drivers use some sort of > > > KBUILD_MODNAME. Why should this driver be any different? > > > > It shouldn't, I'm not saying that at all. I'm only objecting to the > > insistance that this be something worthwhile for 3.3-final which should > > be out any day now. > > Since its an API we could settle on the new string, which is already in > distro use. I don't really understand, but in the end, it's not up to me, it's up to the network maintainer when he wants to merge this to Linus. If it were up to me, I would wait for 3.4. good luck, greg k-h