From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754086Ab2CHVLN (ORCPT ); Thu, 8 Mar 2012 16:11:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58019 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920Ab2CHVLK (ORCPT ); Thu, 8 Mar 2012 16:11:10 -0500 Date: Thu, 8 Mar 2012 16:10:56 -0500 From: Dave Jones To: Andrew Morton Cc: "Aneesh Kumar K.V" , linux-mm@kvack.org, jboyer@redhat.com, tyhicks@canonical.com, linux-kernel@vger.kernel.org, Al Viro , Peter Zijlstra , Mimi Zohar Subject: Re: [PATCH] hugetlbfs: lockdep annotate root inode properly Message-ID: <20120308211055.GA12161@redhat.com> Mail-Followup-To: Dave Jones , Andrew Morton , "Aneesh Kumar K.V" , linux-mm@kvack.org, jboyer@redhat.com, tyhicks@canonical.com, linux-kernel@vger.kernel.org, Al Viro , Peter Zijlstra , Mimi Zohar References: <1331198116-13670-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20120308130256.c7855cbd.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120308130256.c7855cbd.akpm@linux-foundation.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 08, 2012 at 01:02:56PM -0800, Andrew Morton wrote: > > ====================================================== > > [ INFO: possible circular locking dependency detected ] > > 3.3.0-rc4+ #190 Not tainted > > ------------------------------------------------------- > > shared/1568 is trying to acquire lock: > > (&sb->s_type->i_mutex_key#12){+.+.+.}, at: [] hugetlbfs_file_mmap+0x7d/0x108 > > > > but task is already holding lock: > > (&mm->mmap_sem){++++++}, at: [] sys_mmap_pgoff+0xd4/0x12f > > > > which lock already depends on the new lock. > > > > Why have these lockdep warnings started coming out now - was the VFS > changed to newly take i_mutex somewhere in the directory handling? This has been happening for almost a year! https://lkml.org/lkml/2011/4/15/272 See also https://lkml.org/lkml/2012/2/16/498 Dave