From: Oleg Nesterov <oleg@redhat.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] genirq: Get rid of unnecessary IRQTF_DIED flag
Date: Fri, 9 Mar 2012 16:06:12 +0100 [thread overview]
Message-ID: <20120309150612.GA7353@redhat.com> (raw)
In-Reply-To: <20120309135958.GD2114@dhcp-26-207.brq.redhat.com>
Of course I can't ack this, but afaics the whole series looks fine.
Only one minor nit,
On 03/09, Alexander Gordeev wrote:
>
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -60,8 +60,8 @@ static void irq_wake_thread(struct irq_desc *desc, struct irqaction *action)
> * device interrupt, so no irq storm is lurking. If the
> * RUNTHREAD bit is already set, nothing to do.
> */
> - if (test_bit(IRQTF_DIED, &action->thread_flags) ||
> - test_and_set_bit(IRQTF_RUNTHREAD, &action->thread_flags))
> + if (test_and_set_bit(IRQTF_RUNTHREAD, &action->thread_flags) ||
> + (action->thread->flags & PF_EXITING))
> return;
perhaps it makes sense to check PF_EXITING first, we do not want
to set IRQTF_RUNTHREAD in this case. I think this doesn't really
matter (and the check is obviously racy anyway), just looks a bit
confusing.
Oleg.
next prev parent reply other threads:[~2012-03-09 15:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 13:59 [PATCH 4/4] genirq: Get rid of unnecessary IRQTF_DIED flag Alexander Gordeev
2012-03-09 15:06 ` Oleg Nesterov [this message]
2012-03-09 16:17 ` Thomas Gleixner
2012-03-12 11:38 ` Alexander Gordeev
2012-03-12 15:10 ` Alexander Gordeev
2012-03-09 21:13 ` [tip:irq/core] " tip-bot for Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309150612.GA7353@redhat.com \
--to=oleg@redhat.com \
--cc=agordeev@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox