From: Borislav Petkov <bp@amd64.org>
To: Kees Cook <keescook@chromium.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Andy Lutomirski <luto@mit.edu>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Frysinger <vapier@gentoo.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: use enum instead of literals for trap values
Date: Fri, 9 Mar 2012 19:28:29 +0100 [thread overview]
Message-ID: <20120309182829.GA13745@aftab> (raw)
In-Reply-To: <CAGXu5jKHJGmTktKNYDmpZziKRLM-bw-dTK5tboR706J_s6j7NQ@mail.gmail.com>
On Fri, Mar 09, 2012 at 10:21:52AM -0800, Kees Cook wrote:
> > I have to admit personally to prefer something like X86_XCP_XX where XX
> > is the two-letter code that the Intel documentation uses for that trap,
> > i.e. #GP, #BR, #MC and so on.
>
> We need a single person to decide on this bike shed color. :) If the
> list of enum names can be agreed on, I'll be happy to do the
> search/replace for it.
Well,
here are my 2¢: I agree with hpa because
a) it maps the CPU vendor documentation
b) it is nicely short
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-03-09 18:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 7:42 [PATCH] x86: use enum instead of literals for trap values Kees Cook
2012-03-09 9:28 ` Ingo Molnar
2012-03-09 16:30 ` Kees Cook
2012-03-09 17:57 ` H. Peter Anvin
2012-03-09 18:21 ` Kees Cook
2012-03-09 18:28 ` Borislav Petkov [this message]
2012-03-09 18:52 ` Steven Rostedt
2012-03-09 20:10 ` H. Peter Anvin
2012-03-09 22:13 ` Ingo Molnar
2012-03-09 22:23 ` H. Peter Anvin
2012-03-10 8:34 ` Pekka Enberg
2012-03-09 18:54 ` Kees Cook
2012-03-09 19:08 ` Borislav Petkov
2012-03-09 19:14 ` Steven Rostedt
2012-03-09 19:58 ` Kees Cook
2012-03-09 20:13 ` H. Peter Anvin
2012-03-09 20:21 ` Steven Rostedt
2012-03-10 10:15 ` Borislav Petkov
2012-03-10 13:54 ` Steven Rostedt
2012-03-10 14:27 ` Borislav Petkov
2012-03-11 7:52 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2013-01-22 22:44 [PATCH] x86: Use " John Kacur
2013-02-01 17:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120309182829.GA13745@aftab \
--to=bp@amd64.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox