[PATCH] regmap: Fix missing prototype of devres_alloc() and friends

[PATCH] regmap: Fix missing prototype of devres_alloc() and friends

[Stephen Warren]

regmap.s uses devres_alloc() and others that are prototyped in device.h.
Include that to solve the following:

drivers/base/regmap/regmap.c: In function 'devm_regmap_init':
drivers/base/regmap/regmap.c:331:2: error: implicit declaration of function 'devres_alloc' [-Werror=implicit-function-declaration]
drivers/base/regmap/regmap.c:338:3: error: implicit declaration of function 'devres_add' [-Werror=implicit-function-declaration]
drivers/base/regmap/regmap.c:340:3: error: implicit declaration of function 'devres_free' [-Werror=implicit-function-declaration]
drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
drivers/base/regmap/regmap.c:421:5: error: implicit declaration of function 'dev_err' [-Werror=implicit-function-declaration]

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
 drivers/base/regmap/regmap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index e1a4097..7a3f535 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -10,6 +10,7 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/device.h>
 #include <linux/slab.h>
 #include <linux/export.h>
 #include <linux/mutex.h>
-- 
1.7.0.4

Re: [PATCH] regmap: Fix missing prototype of devres_alloc() and friends

[Paul Gortmaker]

[[PATCH] regmap: Fix missing prototype of devres_alloc() and friends] On 09/03/2012 (Fri 13:17) Stephen Warren wrote:

> regmap.s uses devres_alloc() and others that are prototyped in device.h.
> Include that to solve the following:

Thanks, I've already taken care of this earlier today.

http://marc.info/?l=linux-next&m=133130596327850&w=2

Paul.

> 
> drivers/base/regmap/regmap.c: In function 'devm_regmap_init':
> drivers/base/regmap/regmap.c:331:2: error: implicit declaration of function 'devres_alloc' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c:338:3: error: implicit declaration of function 'devres_add' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c:340:3: error: implicit declaration of function 'devres_free' [-Werror=implicit-function-declaration]
> drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
> drivers/base/regmap/regmap.c:421:5: error: implicit declaration of function 'dev_err' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  drivers/base/regmap/regmap.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
> index e1a4097..7a3f535 100644
> --- a/drivers/base/regmap/regmap.c
> +++ b/drivers/base/regmap/regmap.c
> @@ -10,6 +10,7 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#include <linux/device.h>
>  #include <linux/slab.h>
>  #include <linux/export.h>
>  #include <linux/mutex.h>
> -- 
> 1.7.0.4
> 

Re: [PATCH] regmap: Fix missing prototype of devres_alloc() and friends

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

On Fri, Mar 09, 2012 at 03:30:00PM -0500, Paul Gortmaker wrote:
> [[PATCH] regmap: Fix missing prototype of devres_alloc() and friends] On 09/03/2012 (Fri 13:17) Stephen Warren wrote:

> > regmap.s uses devres_alloc() and others that are prototyped in device.h.
> > Include that to solve the following:

> Thanks, I've already taken care of this earlier today.

> http://marc.info/?l=linux-next&m=133130596327850&w=2

So, I was going to repeat my question to Stephen.  But then I looked at
-next and found that someone had gone and randomly deleted the inclusion
of device.h without ever telling me, looking the git logs I see that
this was done in commit 3a55cc ("device.h: audit and cleanup users in
main include dir" - notice what I'm doing here and including the human
readable subject line and not just the git hash) which comes from you.

In order to avoid breaking bisection I've applied Stephen's fix.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] regmap: Fix missing prototype of devres_alloc() and friends

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

On Fri, Mar 09, 2012 at 01:17:28PM -0700, Stephen Warren wrote:
> regmap.s uses devres_alloc() and others that are prototyped in device.h.
> Include that to solve the following:
> 
> drivers/base/regmap/regmap.c: In function 'devm_regmap_init':

Hrm, what I want to know here is how you're managing to build this file
without including regmap.h which includes device.h.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]