[PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get DMA device info

[PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get DMA device info

[Tomoya MORINAGA]

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
---
 drivers/spi/spi-topcliff-pch.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 99ec279..fcd9462 100644
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -920,7 +920,8 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
 	dma_cap_set(DMA_SLAVE, mask);
 
 	/* Get DMA's dev information */
-	dma_dev = pci_get_bus_and_slot(2, PCI_DEVFN(12, 0));
+	dma_dev = pci_get_bus_and_slot(data->board_dat->pdev->bus->number,
+				       PCI_DEVFN(12, 0));
 
 	/* Set Tx DMA */
 	param = &dma->param_tx;
-- 
1.7.4.4

Re: [PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get DMA device info

[Tomoya MORINAGA]

Hi Grant.

More than a month has been passed since I posted the following patches.
However still not reviewed yet.

[PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get
DMA device info
[PATCH 2/4] spi-topcliff-pch: Fix issue for transmitting over 4KByte
[PATCH 3/4][RESEND] spi-topcliff-pch: supports a spi mode setup and
bit order setup by IO control
[PATCH 4/4] spi-topcliff-pch: add recovery processing in case wait-event timeout

Could you review these ?

thanks,
tomoya

2011/12/9 Tomoya MORINAGA <tomoya.rohm@gmail.com>:
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> ---
>  drivers/spi/spi-topcliff-pch.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index 99ec279..fcd9462 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -920,7 +920,8 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
>        dma_cap_set(DMA_SLAVE, mask);
>
>        /* Get DMA's dev information */
> -       dma_dev = pci_get_bus_and_slot(2, PCI_DEVFN(12, 0));
> +       dma_dev = pci_get_bus_and_slot(data->board_dat->pdev->bus->number,
> +                                      PCI_DEVFN(12, 0));
>
>        /* Set Tx DMA */
>        param = &dma->param_tx;
> --
> 1.7.4.4
>

Re: [PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get DMA device info

[Grant Likely]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1872 bytes --]

On Thu, 19 Jan 2012 11:34:43 +0900, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> Hi Grant.
> 
> More than a month has been passed since I posted the following patches.
> However still not reviewed yet.
> 
> [PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get
> DMA device info
> [PATCH 2/4] spi-topcliff-pch: Fix issue for transmitting over 4KByte
> [PATCH 3/4][RESEND] spi-topcliff-pch: supports a spi mode setup and
> bit order setup by IO control
> [PATCH 4/4] spi-topcliff-pch: add recovery processing in case wait-event timeout
> 
> Could you review these ?

I'm working through my backlog now.  A big part of the problem is my
method of dealing with pending patches really sucked.  I've switched
to using notmuch-vim, which seems to be a much better system for tracking
email that I need to pay attention to.

g.

> 
> thanks,
> tomoya
> 
> 2011/12/9 Tomoya MORINAGA <tomoya.rohm@gmail.com>:
> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> > ---
> >  drivers/spi/spi-topcliff-pch.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> > index 99ec279..fcd9462 100644
> > --- a/drivers/spi/spi-topcliff-pch.c
> > +++ b/drivers/spi/spi-topcliff-pch.c
> > @@ -920,7 +920,8 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
> >        dma_cap_set(DMA_SLAVE, mask);
> >
> >        /* Get DMA's dev information */
> > -       dma_dev = pci_get_bus_and_slot(2, PCI_DEVFN(12, 0));
> > +       dma_dev = pci_get_bus_and_slot(data->board_dat->pdev->bus->number,
> > +                                      PCI_DEVFN(12, 0));
> >
> >        /* Set Tx DMA */
> >        param = &dma->param_tx;
> > --
> > 1.7.4.4
> >

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.

Re: [PATCH 1/4] spi-topcliff-pch: Modify pci-bus number dynamically to get DMA device info

[Grant Likely]

On Fri,  9 Dec 2011 13:11:42 +0900, Tomoya MORINAGA <tomoya.rohm@gmail.com> wrote:
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
> ---
>  drivers/spi/spi-topcliff-pch.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
> index 99ec279..fcd9462 100644
> --- a/drivers/spi/spi-topcliff-pch.c
> +++ b/drivers/spi/spi-topcliff-pch.c
> @@ -920,7 +920,8 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
>  	dma_cap_set(DMA_SLAVE, mask);
>  
>  	/* Get DMA's dev information */
> -	dma_dev = pci_get_bus_and_slot(2, PCI_DEVFN(12, 0));
> +	dma_dev = pci_get_bus_and_slot(data->board_dat->pdev->bus->number,
> +				       PCI_DEVFN(12, 0));

Applied, thanks

g.