* [PATCH 0/1] ARM: AT91: drivers: cleanup patches from Arnd Bergmann @ 2012-03-10 18:53 Alan Ott 2012-03-10 18:54 ` [PATCH 1/1] ata: AT91 ata driver requires specific platforms Alan Ott 2012-03-10 21:36 ` [PATCH v2 0/2] " Alan Ott 0 siblings, 2 replies; 10+ messages in thread From: Alan Ott @ 2012-03-10 18:53 UTC (permalink / raw) To: Jeff Garzik, linux-ide, linux-kernel; +Cc: Alan Ott Hello, I'm helping Arnd Bergmann get some of his cleanup patches upstream. This covers the AT91 related drivers. Thanks, Alan. Arnd Bergmann (1): ata: AT91 ata driver requires specific platforms drivers/ata/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] ata: AT91 ata driver requires specific platforms 2012-03-10 18:53 [PATCH 0/1] ARM: AT91: drivers: cleanup patches from Arnd Bergmann Alan Ott @ 2012-03-10 18:54 ` Alan Ott 2012-03-10 19:56 ` Ben Dooks 2012-03-10 21:36 ` [PATCH v2 0/2] " Alan Ott 1 sibling, 1 reply; 10+ messages in thread From: Alan Ott @ 2012-03-10 18:54 UTC (permalink / raw) To: Jeff Garzik, linux-ide, linux-kernel; +Cc: Arnd Bergmann, Alan Ott From: Arnd Bergmann <arnd@arndb.de> This driver uses registers defined in a per-soc header file. Since not every soc in the at91 platform defines those, make the Kconfig option dependent on specifically the socs that do. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Alan Ott <alan@signal11.us> --- drivers/ata/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 6bdedd7..16c6b78 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -731,6 +731,7 @@ config PATA_AT32 config PATA_AT91 tristate "PATA support for AT91SAM9260" depends on ARM && ARCH_AT91 + depends on ARCH_AT91SAM9260 || ARCH_AT91SAM9G20 || ARCH_AT91SAM9261 || ARCH_AT91SAM9G10 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45 || ARCH_AT91CAP9 help This option enables support for IDE devices on the Atmel AT91SAM9260 SoC. -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/1] ata: AT91 ata driver requires specific platforms 2012-03-10 18:54 ` [PATCH 1/1] ata: AT91 ata driver requires specific platforms Alan Ott @ 2012-03-10 19:56 ` Ben Dooks 0 siblings, 0 replies; 10+ messages in thread From: Ben Dooks @ 2012-03-10 19:56 UTC (permalink / raw) To: Alan Ott; +Cc: Jeff Garzik, linux-ide, linux-kernel, Arnd Bergmann On Sat, Mar 10, 2012 at 01:54:12PM -0500, Alan Ott wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This driver uses registers defined in a per-soc header file. > Since not every soc in the at91 platform defines those, make > the Kconfig option dependent on specifically the socs that > do. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Alan Ott <alan@signal11.us> > --- > drivers/ata/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6bdedd7..16c6b78 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -731,6 +731,7 @@ config PATA_AT32 > config PATA_AT91 > tristate "PATA support for AT91SAM9260" > depends on ARM && ARCH_AT91 > + depends on ARCH_AT91SAM9260 || ARCH_AT91SAM9G20 || ARCH_AT91SAM9261 || ARCH_AT91SAM9G10 || ARCH_AT91SAM9263 || ARCH_AT91SAM9RL || ARCH_AT91SAM9G45 || ARCH_AT91CAP9 > help How about adding an AT91_HAS_PATA kconfig and having the arch/arm/... Kconfig select it as necessary. It will avoid future fun when another device comes out. -- Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 0/2] ata: AT91 ata driver requires specific platforms 2012-03-10 18:53 [PATCH 0/1] ARM: AT91: drivers: cleanup patches from Arnd Bergmann Alan Ott 2012-03-10 18:54 ` [PATCH 1/1] ata: AT91 ata driver requires specific platforms Alan Ott @ 2012-03-10 21:36 ` Alan Ott 2012-03-10 21:38 ` [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA Alan Ott 2012-03-10 21:39 ` [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA Alan Ott 1 sibling, 2 replies; 10+ messages in thread From: Alan Ott @ 2012-03-10 21:36 UTC (permalink / raw) To: Andrew Victor, Nicolas Ferre, Jean-Christophe Plagniol-Villard, Russell King, Jeff Garzik, linux-arm-kernel, linux-kernel, linux-ide, Arnd Bergmann, Ben Dooks Cc: Alan Ott Based on suggestions from Ben Dooks, This patch now adds an AT91_HAS_PATA kconfig item and the AT91 CPUs which have PATA now select it. The AT91 PATA driver how depends on this kconfig item. Ben, let me know if this is what you had in mind. Alan Ott (2): ARM: AT91: Add parameter for AT91_HAS_PATA ata: AT91 ata driver requires AT91_HAS_PATA arch/arm/mach-at91/Kconfig | 11 +++++++++++ drivers/ata/Kconfig | 1 + 2 files changed, 12 insertions(+), 0 deletions(-) ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA 2012-03-10 21:36 ` [PATCH v2 0/2] " Alan Ott @ 2012-03-10 21:38 ` Alan Ott 2012-03-11 18:38 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-10 21:39 ` [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA Alan Ott 1 sibling, 1 reply; 10+ messages in thread From: Alan Ott @ 2012-03-10 21:38 UTC (permalink / raw) To: Andrew Victor, Nicolas Ferre, Jean-Christophe Plagniol-Villard, Russell King, linux-arm-kernel, linux-kernel Cc: Alan Ott, Arnd Bergmann, Ben Dooks Not all at91 chips have PATA, this parameter will identify which chips do. The determining of which chips support PATA was done by Arnd Bergmann. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Alan Ott <alan@signal11.us> CC: Ben Dooks <ben-linux@fluff.org> --- arch/arm/mach-at91/Kconfig | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig index 71feb00..9eeeabe 100644 --- a/arch/arm/mach-at91/Kconfig +++ b/arch/arm/mach-at91/Kconfig @@ -24,6 +24,9 @@ config AT91_SAM9_ALT_RESET config AT91_SAM9G45_RESET bool +config AT91_HAS_PATA + bool + menu "Atmel AT91 System-on-Chip" choice @@ -46,6 +49,7 @@ config ARCH_AT91SAM9260 select HAVE_AT91_USART5 select HAVE_NET_MACB select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9261 bool "AT91SAM9261" @@ -54,6 +58,7 @@ config ARCH_AT91SAM9261 select HAVE_FB_ATMEL select HAVE_AT91_DBGU0 select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9G10 bool "AT91SAM9G10" @@ -62,6 +67,7 @@ config ARCH_AT91SAM9G10 select HAVE_AT91_DBGU0 select HAVE_FB_ATMEL select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9263 bool "AT91SAM9263" @@ -71,6 +77,7 @@ config ARCH_AT91SAM9263 select HAVE_NET_MACB select HAVE_AT91_DBGU1 select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9RL bool "AT91SAM9RL" @@ -80,6 +87,7 @@ config ARCH_AT91SAM9RL select HAVE_FB_ATMEL select HAVE_AT91_DBGU0 select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9G20 bool "AT91SAM9G20" @@ -91,6 +99,7 @@ config ARCH_AT91SAM9G20 select HAVE_AT91_USART5 select HAVE_NET_MACB select AT91_SAM9_ALT_RESET + select AT91_HAS_PATA config ARCH_AT91SAM9G45 bool "AT91SAM9G45" @@ -101,6 +110,7 @@ config ARCH_AT91SAM9G45 select HAVE_NET_MACB select HAVE_AT91_DBGU1 select AT91_SAM9G45_RESET + select AT91_HAS_PATA config ARCH_AT91CAP9 bool "AT91CAP9" @@ -110,6 +120,7 @@ config ARCH_AT91CAP9 select HAVE_NET_MACB select HAVE_AT91_DBGU1 select AT91_SAM9G45_RESET + select AT91_HAS_PATA config ARCH_AT91X40 bool "AT91x40" -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA 2012-03-10 21:38 ` [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA Alan Ott @ 2012-03-11 18:38 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-11 21:36 ` Arnd Bergmann 0 siblings, 1 reply; 10+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2012-03-11 18:38 UTC (permalink / raw) To: Alan Ott Cc: Andrew Victor, Nicolas Ferre, Russell King, linux-arm-kernel, linux-kernel, Arnd Bergmann, Ben Dooks On 16:38 Sat 10 Mar , Alan Ott wrote: > Not all at91 chips have PATA, this parameter will identify which > chips do. The determining of which chips support PATA was done > by Arnd Bergmann. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Alan Ott <alan@signal11.us> > CC: Ben Dooks <ben-linux@fluff.org> > --- > arch/arm/mach-at91/Kconfig | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > index 71feb00..9eeeabe 100644 > --- a/arch/arm/mach-at91/Kconfig > +++ b/arch/arm/mach-at91/Kconfig > @@ -24,6 +24,9 @@ config AT91_SAM9_ALT_RESET > config AT91_SAM9G45_RESET > bool > > +config AT91_HAS_PATA > + bool what is the need for this? As we switch to DT, I don't want to track the soc list in the Kconfig anymore if the soc support the PATA will be describe in the DT Best Regards, J. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA 2012-03-11 18:38 ` Jean-Christophe PLAGNIOL-VILLARD @ 2012-03-11 21:36 ` Arnd Bergmann 0 siblings, 0 replies; 10+ messages in thread From: Arnd Bergmann @ 2012-03-11 21:36 UTC (permalink / raw) To: Jean-Christophe PLAGNIOL-VILLARD Cc: Alan Ott, Andrew Victor, Nicolas Ferre, Russell King, linux-arm-kernel, linux-kernel, Ben Dooks On Sunday 11 March 2012, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig > > index 71feb00..9eeeabe 100644 > > --- a/arch/arm/mach-at91/Kconfig > > +++ b/arch/arm/mach-at91/Kconfig > > @@ -24,6 +24,9 @@ config AT91_SAM9_ALT_RESET > > config AT91_SAM9G45_RESET > > bool > > > > +config AT91_HAS_PATA > > + bool > what is the need for this? > > As we switch to DT, I don't want to track the soc list in the Kconfig anymore > if the soc support the PATA will be describe in the DT > When I originally wrote the patch, I was hitting build errors when trying to enable the at91 pata driver on socs that don't have the right declarations in their headers. If that has been resolved in a better way already, this patch can be dropped. Arnd ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA 2012-03-10 21:36 ` [PATCH v2 0/2] " Alan Ott 2012-03-10 21:38 ` [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA Alan Ott @ 2012-03-10 21:39 ` Alan Ott 2012-03-11 10:10 ` Sergei Shtylyov 2012-03-13 20:46 ` Jeff Garzik 1 sibling, 2 replies; 10+ messages in thread From: Alan Ott @ 2012-03-10 21:39 UTC (permalink / raw) To: Jeff Garzik, linux-ide, linux-kernel; +Cc: Alan Ott, Arnd Bergmann, Ben Dooks This driver uses registers defined in a per-soc header file. Since not every soc in the at91 platform defines those, make the Kconfig option dependent on those which define AT91_HAS_PATA. This is based on a patch by Arnd Bergmann. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Alan Ott <alan@signal11.us> CC: Ben Dooks <ben-linux@fluff.org> --- drivers/ata/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 6bdedd7..fdb8c90 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -731,6 +731,7 @@ config PATA_AT32 config PATA_AT91 tristate "PATA support for AT91SAM9260" depends on ARM && ARCH_AT91 + depends on AT91_HAS_PATA help This option enables support for IDE devices on the Atmel AT91SAM9260 SoC. -- 1.7.0.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA 2012-03-10 21:39 ` [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA Alan Ott @ 2012-03-11 10:10 ` Sergei Shtylyov 2012-03-13 20:46 ` Jeff Garzik 1 sibling, 0 replies; 10+ messages in thread From: Sergei Shtylyov @ 2012-03-11 10:10 UTC (permalink / raw) To: Alan Ott; +Cc: Jeff Garzik, linux-ide, linux-kernel, Arnd Bergmann, Ben Dooks Hello. On 11-03-2012 1:39, Alan Ott wrote: > This driver uses registers defined in a per-soc header file. > Since not every soc in the at91 platform defines those, make > the Kconfig option dependent on those which define > AT91_HAS_PATA. > This is based on a patch by Arnd Bergmann. > Signed-off-by: Arnd Bergmann<arnd@arndb.de> > Signed-off-by: Alan Ott<alan@signal11.us> > CC: Ben Dooks<ben-linux@fluff.org> > --- > drivers/ata/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6bdedd7..fdb8c90 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -731,6 +731,7 @@ config PATA_AT32 > config PATA_AT91 > tristate "PATA support for AT91SAM9260" > depends on ARM && ARCH_AT91 Is this line still needed? > + depends on AT91_HAS_PATA > help > This option enables support for IDE devices on the Atmel AT91SAM9260 SoC. WBR, Sergei ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA 2012-03-10 21:39 ` [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA Alan Ott 2012-03-11 10:10 ` Sergei Shtylyov @ 2012-03-13 20:46 ` Jeff Garzik 1 sibling, 0 replies; 10+ messages in thread From: Jeff Garzik @ 2012-03-13 20:46 UTC (permalink / raw) To: Alan Ott; +Cc: linux-ide, linux-kernel, Arnd Bergmann, Ben Dooks On 03/10/2012 04:39 PM, Alan Ott wrote: > This driver uses registers defined in a per-soc header file. > Since not every soc in the at91 platform defines those, make > the Kconfig option dependent on those which define > AT91_HAS_PATA. > > This is based on a patch by Arnd Bergmann. > > Signed-off-by: Arnd Bergmann<arnd@arndb.de> > Signed-off-by: Alan Ott<alan@signal11.us> > CC: Ben Dooks<ben-linux@fluff.org> > --- > drivers/ata/Kconfig | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 6bdedd7..fdb8c90 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -731,6 +731,7 @@ config PATA_AT32 > config PATA_AT91 > tristate "PATA support for AT91SAM9260" > depends on ARM&& ARCH_AT91 > + depends on AT91_HAS_PATA > help Acked-by: Jeff Garzik <jgarzik@redhat.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-03-13 20:46 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-03-10 18:53 [PATCH 0/1] ARM: AT91: drivers: cleanup patches from Arnd Bergmann Alan Ott 2012-03-10 18:54 ` [PATCH 1/1] ata: AT91 ata driver requires specific platforms Alan Ott 2012-03-10 19:56 ` Ben Dooks 2012-03-10 21:36 ` [PATCH v2 0/2] " Alan Ott 2012-03-10 21:38 ` [PATCH v2 1/2] ARM: AT91: Add parameter for AT91_HAS_PATA Alan Ott 2012-03-11 18:38 ` Jean-Christophe PLAGNIOL-VILLARD 2012-03-11 21:36 ` Arnd Bergmann 2012-03-10 21:39 ` [PATCH v2 2/2] ata: AT91 ata driver requires AT91_HAS_PATA Alan Ott 2012-03-11 10:10 ` Sergei Shtylyov 2012-03-13 20:46 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox