From: Grant Likely <grant.likely@secretlab.ca>
To: wharms@bfs.de, Dan Carpenter <dan.carpenter@oracle.com>
Cc: spi-devel-general@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] spi: release lock on error path in spi_pump_messages()
Date: Sat, 10 Mar 2012 19:43:07 -0700 [thread overview]
Message-ID: <20120311024307.AA5E33E0950@localhost> (raw)
In-Reply-To: <4F5B2113.3060103@bfs.de>
On Sat, 10 Mar 2012 10:38:27 +0100, walter harms <wharms@bfs.de> wrote:
>
>
> Am 10.03.2012 09:57, schrieb Dan Carpenter:
> > We should release the lock here and enable IRQs before returning.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> > index 5ae1e84..ab1bdce 100644
> > --- a/drivers/spi/spi.c
> > +++ b/drivers/spi/spi.c
> > @@ -535,6 +535,7 @@ static void spi_pump_messages(struct kthread_work *work)
> > if (ret) {
> > dev_err(&master->dev,
> > "failed to unprepare transfer hardware\n");
> > + spin_unlock_irqrestore(&master->queue_lock, flags);
> > return;
> > }
> > }
>
>
> hi Dan,
> do you want to protect dev_err() by a spn_lock ?
Applied, after moving unlock above the dev_err.
g.
next prev parent reply other threads:[~2012-03-11 2:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-10 8:57 [patch] spi: release lock on error path in spi_pump_messages() Dan Carpenter
2012-03-10 9:38 ` walter harms
2012-03-11 2:43 ` Grant Likely [this message]
2012-03-11 6:20 ` Dan Carpenter
2012-03-11 13:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311024307.AA5E33E0950@localhost \
--to=grant.likely@secretlab.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox