public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Len Brown <len.brown@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] floppy: revert floppy disable halt warning
Date: Sun, 11 Mar 2012 09:38:53 -0700	[thread overview]
Message-ID: <20120311093853.04f049c2@s6510.linuxnetplumber.net> (raw)

Remove the stupid floppy disable halt warning. It is meaningless since
the API is local to floppy driver.  Our boot scripts check for the
floppy drive, and this causes the warning to trigger every time. This
confuses support, breaks automated tests that look for backtraces on
boot,  and adds no value.  

The message is being displayed to the wrong audience, it looks like it
was intended as a compromise of a long discussion on LKML about
supporting older x86 hardware; but users don't know or understand what
it is saying.

If you want to change halt handling then just fix
the floppy driver, don't whine about it.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/drivers/block/floppy.c	2012-03-11 09:27:52.866459327 -0700
+++ b/drivers/block/floppy.c	2012-03-11 09:28:29.286579201 -0700
@@ -1037,7 +1037,6 @@ static void floppy_disable_hlt(void)
 {
 	unsigned long flags;
 
-	WARN_ONCE(1, "floppy_disable_hlt() scheduled for removal in 2012");
 	spin_lock_irqsave(&floppy_hlt_lock, flags);
 	if (!hlt_disabled) {
 		hlt_disabled = 1;

             reply	other threads:[~2012-03-11 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-11 16:38 Stephen Hemminger [this message]
2012-03-27 23:26 ` [PATCH] floppy: revert floppy disable halt warning Andrew Morton
2012-03-28  0:24   ` Josh Boyer
2012-03-28  6:40     ` Ingo Molnar
2012-03-28  7:20       ` H. Peter Anvin
2012-03-28  7:34         ` Ingo Molnar
2012-03-28 10:46         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120311093853.04f049c2@s6510.linuxnetplumber.net \
    --to=shemminger@vyatta.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox