From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] regmap: add structs to fix build warnings when REGMAP is not enabled
Date: Sun, 11 Mar 2012 11:57:58 +0000 [thread overview]
Message-ID: <20120311115757.GD3233@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F5A5AAD.1000105@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Fri, Mar 09, 2012 at 11:31:57AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Fix build warnings when CONFIG_REGMAP is not enabled by providing
> struct forward references.
This isn't a great approach - you've put the forward declarations into
the ifdef which is at best needless (if they conflict with anything real
something went badly wrong) and for the register defaults the chances
are anything actually trying to use that stub needs to know about the
definition so the ifdef should be pulled further down the function.
I've done something better.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-11 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 8:11 linux-next: Tree for Mar 9 Stephen Rothwell
2012-03-09 19:31 ` [PATCH -next] regmap: add structs to fix build warnings when REGMAP is not enabled Randy Dunlap
2012-03-11 11:57 ` Mark Brown [this message]
2012-03-09 20:30 ` linux-next: Tree for Mar 9 (netfilter) Randy Dunlap
2012-03-10 11:21 ` Pablo Neira Ayuso
2012-03-10 16:45 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311115757.GD3233@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).