From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Michal Hocko <mhocko@suse.cz>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix idle ticks in cpu summary line of /proc/stat
Date: Sun, 11 Mar 2012 18:26:21 -0400 [thread overview]
Message-ID: <20120311182621.41674b39@de.ibm.com> (raw)
Git commit 09a1d34f8535ecf9 "nohz: Make idle/iowait counter update conditional"
introduced a bug in regard to cpu hotplug. The effect is that the number
of idle ticks in the cpu summary line in /proc/stat is still counting
ticks for offline cpus.
Reproduction is easy, just start a workload that keeps all cpus busy,
switch off one or more cpus and then watch the idle field in top.
On a dual-core with one cpu 100% busy and one offline cpu you will get
something like this:
%Cpu(s): 48.7 us, 1.3 sy, 0.0 ni, 50.0 id, 0.0 wa, 0.0 hi, 0.0 si, 0.0 st
The problem is that an offline cpu still has ts->idle_active == 1.
To fix this get_cpu_idle_time_us and get_cpu_iowait_time_us
should check for offline cpus.
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---
kernel/time/tick-sched.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -213,7 +213,7 @@ u64 get_cpu_idle_time_us(int cpu, u64 *l
struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
ktime_t now, idle;
- if (!tick_nohz_enabled)
+ if (!tick_nohz_enabled || !cpu_online(cpu))
return -1;
now = ktime_get();
@@ -254,7 +254,7 @@ u64 get_cpu_iowait_time_us(int cpu, u64
struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu);
ktime_t now, iowait;
- if (!tick_nohz_enabled)
+ if (!tick_nohz_enabled || !cpu_online(cpu))
return -1;
now = ktime_get();
next reply other threads:[~2012-03-11 22:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-11 22:26 Martin Schwidefsky [this message]
2012-03-12 12:17 ` [PATCH] fix idle ticks in cpu summary line of /proc/stat Michal Hocko
2012-03-12 14:17 ` Martin Schwidefsky
2012-03-12 14:48 ` Srivatsa S. Bhat
2012-03-12 15:39 ` Michal Hocko
2012-03-12 20:41 ` Martin Schwidefsky
2012-03-13 8:07 ` [PATCH v2] " Michal Hocko
2012-03-13 8:32 ` Srivatsa S. Bhat
2012-07-18 11:52 ` Martin Schwidefsky
2012-07-18 12:21 ` Srivatsa S. Bhat
2012-03-29 10:42 ` Thomas Gleixner
2012-03-30 10:23 ` Martin Schwidefsky
2012-03-30 10:41 ` Michal Hocko
2012-03-30 11:01 ` Srivatsa S. Bhat
2012-03-30 13:58 ` [tip:timers/core] proc: stats: Use arch_idle_time for idle and iowait times if available tip-bot for Martin Schwidefsky
2012-03-30 22:54 ` Andrew Morton
2012-04-02 6:51 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120311182621.41674b39@de.ibm.com \
--to=schwidefsky@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox