The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: ipv4: Standardize prefixes for message logging
Date: Mon, 12 Mar 2012 17:05:58 -0700 (PDT)	[thread overview]
Message-ID: <20120312.170558.584205292599435892.davem@davemloft.net> (raw)
In-Reply-To: <1331571812.13200.23.camel@joe2Laptop>

From: Joe Perches <joe@perches.com>
Date: Mon, 12 Mar 2012 10:03:32 -0700

> Add #define pr_fmt(fmt) as appropriate.
> 
> Add "IPv4: ", "TCP: ", and "IPsec: " to appropriate files.
> Standardize on "UDPLite: " for appropriate uses.
> Some prefixes were previously "UDPLITE: " and "UDP-Lite: ".
> 
> Add KBUILD_MODNAME ": " to icmp and gre.
> Remove embedded prefixes as appropriate.
> 
> Add missing "\n" to pr_info in gre.c.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Looks good, and applied, but I left out this hunk:

> diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> index 63b64c4..56d6768 100644
> --- a/net/ipv4/ipcomp.c
> +++ b/net/ipv4/ipcomp.c
> @@ -13,6 +13,7 @@
>   *   - Compression stats.
>   *   - Adaptive compression.
>   */
> +
>  #include <linux/module.h>
>  #include <linux/err.h>
>  #include <linux/rtnetlink.h>

As it seemed accidental, if not gratuitous.

  reply	other threads:[~2012-03-13  0:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12  4:36 [PATCH net-next] net: Convert printks to pr_<level> Joe Perches
2012-03-12  6:48 ` David Miller
2012-03-12 17:03   ` [PATCH net-next] net: ipv4: Standardize prefixes for message logging Joe Perches
2012-03-13  0:05     ` David Miller [this message]
2012-03-13  0:35       ` Joe Perches
2012-03-19 21:00         ` Joe Perches
2012-03-19 21:03           ` David Miller
2012-03-19 21:14             ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312.170558.584205292599435892.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox