From: Shaohua Li <shli@fusionio.com>
To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Cc: neilb@suse.de, axboe@kernel.dk, Shaohua Li <shli@fusionio.com>
Subject: [patch 1/7] block: makes bio_split support bio without data
Date: Mon, 12 Mar 2012 11:04:13 +0800 [thread overview]
Message-ID: <20120312031305.472465262@fusionio.com> (raw)
In-Reply-To: 20120312030412.375458948@fusionio.com
[-- Attachment #1: bio_split-fix.patch --]
[-- Type: text/plain, Size: 1638 bytes --]
discard bio hasn't data attached. We hit a BUG_ON with such bio. This makes
bio_split works for such bio.
Signed-off-by: Shaohua Li <shli@fusionio.com>
---
fs/bio.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
Index: linux/fs/bio.c
===================================================================
--- linux.orig/fs/bio.c 2012-03-09 16:56:41.203790008 +0800
+++ linux/fs/bio.c 2012-03-12 10:10:40.696612399 +0800
@@ -1492,7 +1492,7 @@ struct bio_pair *bio_split(struct bio *b
trace_block_split(bdev_get_queue(bi->bi_bdev), bi,
bi->bi_sector + first_sectors);
- BUG_ON(bi->bi_vcnt != 1);
+ BUG_ON(bi->bi_vcnt != 1 && bi->bi_vcnt != 0);
BUG_ON(bi->bi_idx != 0);
atomic_set(&bp->cnt, 3);
bp->error = 0;
@@ -1502,17 +1502,19 @@ struct bio_pair *bio_split(struct bio *b
bp->bio2.bi_size -= first_sectors << 9;
bp->bio1.bi_size = first_sectors << 9;
- bp->bv1 = bi->bi_io_vec[0];
- bp->bv2 = bi->bi_io_vec[0];
- bp->bv2.bv_offset += first_sectors << 9;
- bp->bv2.bv_len -= first_sectors << 9;
- bp->bv1.bv_len = first_sectors << 9;
+ if (bi->bi_vcnt != 0) {
+ bp->bv1 = bi->bi_io_vec[0];
+ bp->bv2 = bi->bi_io_vec[0];
+ bp->bv2.bv_offset += first_sectors << 9;
+ bp->bv2.bv_len -= first_sectors << 9;
+ bp->bv1.bv_len = first_sectors << 9;
- bp->bio1.bi_io_vec = &bp->bv1;
- bp->bio2.bi_io_vec = &bp->bv2;
+ bp->bio1.bi_io_vec = &bp->bv1;
+ bp->bio2.bi_io_vec = &bp->bv2;
- bp->bio1.bi_max_vecs = 1;
- bp->bio2.bi_max_vecs = 1;
+ bp->bio1.bi_max_vecs = 1;
+ bp->bio2.bi_max_vecs = 1;
+ }
bp->bio1.bi_end_io = bio_pair_end_1;
bp->bio2.bi_end_io = bio_pair_end_2;
next prev parent reply other threads:[~2012-03-12 3:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 3:04 [patch 0/7] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-12 3:04 ` Shaohua Li [this message]
2012-03-12 3:04 ` [patch 2/7] md: linear supports TRIM Shaohua Li
2012-03-12 3:04 ` [patch 3/7] md: raid 0 " Shaohua Li
2012-03-12 3:04 ` [patch 4/7] md: raid 1 " Shaohua Li
2012-03-12 3:04 ` [patch 5/7] md: raid 10 " Shaohua Li
2012-03-12 3:04 ` [patch 6/7] blk: add plug for blkdev_issue_discard Shaohua Li
2012-03-13 15:51 ` Vivek Goyal
2012-03-13 17:04 ` Martin K. Petersen
2012-03-13 17:14 ` Vivek Goyal
2012-03-13 17:19 ` Martin K. Petersen
2012-03-12 3:04 ` [patch 7/7] blk: use correct sectors limitation for discard request Shaohua Li
2012-03-13 16:00 ` Vivek Goyal
2012-03-12 3:18 ` [patch 0/7] Add TRIM support for raid linear/0/1/10 Roberto Spadim
2012-03-12 18:22 ` Holger Kiehl
[not found] ` <4F5EFEB6.4060402@kernel.org>
2012-03-13 12:22 ` Holger Kiehl
2012-03-13 14:15 ` Shaohua Li
2012-03-13 14:58 ` Roberto Spadim
2012-03-13 15:44 ` Holger Kiehl
2012-03-14 1:30 ` Shaohua Li
2012-03-14 10:25 ` Holger Kiehl
2012-03-14 11:14 ` Shaohua Li
2012-03-14 11:32 ` Shaohua Li
2012-03-14 21:01 ` Holger Kiehl
2012-03-14 21:13 ` Holger Kiehl
2012-03-15 2:39 ` Shaohua Li
2012-03-15 9:08 ` Holger Kiehl
2012-03-16 2:19 ` Shaohua Li
[not found] ` <4F5EA8E9.5010502@fusionio.com>
2012-03-14 2:25 ` NeilBrown
2012-03-14 2:24 ` NeilBrown
2012-03-14 2:47 ` Shaohua Li
2012-03-17 18:14 ` Mark Lord
2012-03-18 2:03 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312031305.472465262@fusionio.com \
--to=shli@fusionio.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox