public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shaohua Li <shli@fusionio.com>
To: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Cc: neilb@suse.de, axboe@kernel.dk, Shaohua Li <shli@fusionio.com>
Subject: [patch 7/7] blk: use correct sectors limitation for discard request
Date: Mon, 12 Mar 2012 11:04:19 +0800	[thread overview]
Message-ID: <20120312031306.030156009@fusionio.com> (raw)
In-Reply-To: 20120312030412.375458948@fusionio.com

[-- Attachment #1: blk-discard-merge-maxsector-check.patch --]
[-- Type: text/plain, Size: 2225 bytes --]

max_discard_sectors doesn't equal to max_sectors/max_hw_sectors. Without this,
discard request merge might be ignored.

Signed-off-by: Shaohua Li <shli@fusionio.com>
---
 block/blk-merge.c      |    9 +++++++--
 include/linux/blkdev.h |    5 +++++
 2 files changed, 12 insertions(+), 2 deletions(-)

Index: linux/block/blk-merge.c
===================================================================
--- linux.orig/block/blk-merge.c	2012-03-09 14:05:35.562062857 +0800
+++ linux/block/blk-merge.c	2012-03-09 14:07:55.432062246 +0800
@@ -228,13 +228,16 @@ no_merge:
 int ll_back_merge_fn(struct request_queue *q, struct request *req,
 		     struct bio *bio)
 {
-	unsigned short max_sectors;
+	unsigned int max_sectors;
 
 	if (unlikely(req->cmd_type == REQ_TYPE_BLOCK_PC))
 		max_sectors = queue_max_hw_sectors(q);
 	else
 		max_sectors = queue_max_sectors(q);
 
+	if (unlikely(req->cmd_flags & REQ_DISCARD))
+		max_sectors = queue_max_discard_sectors(q);
+
 	if (blk_rq_sectors(req) + bio_sectors(bio) > max_sectors) {
 		req->cmd_flags |= REQ_NOMERGE;
 		if (req == q->last_merge)
@@ -252,13 +255,15 @@ int ll_back_merge_fn(struct request_queu
 int ll_front_merge_fn(struct request_queue *q, struct request *req,
 		      struct bio *bio)
 {
-	unsigned short max_sectors;
+	unsigned int max_sectors;
 
 	if (unlikely(req->cmd_type == REQ_TYPE_BLOCK_PC))
 		max_sectors = queue_max_hw_sectors(q);
 	else
 		max_sectors = queue_max_sectors(q);
 
+	if (unlikely(req->cmd_flags & REQ_DISCARD))
+		max_sectors = queue_max_discard_sectors(q);
 
 	if (blk_rq_sectors(req) + bio_sectors(bio) > max_sectors) {
 		req->cmd_flags |= REQ_NOMERGE;
Index: linux/include/linux/blkdev.h
===================================================================
--- linux.orig/include/linux/blkdev.h	2012-03-09 14:05:35.562062857 +0800
+++ linux/include/linux/blkdev.h	2012-03-09 14:07:55.432062246 +0800
@@ -1006,6 +1006,11 @@ static inline unsigned int queue_max_hw_
 	return q->limits.max_hw_sectors;
 }
 
+static inline unsigned int queue_max_discard_sectors(struct request_queue *q)
+{
+	return q->limits.max_discard_sectors;
+}
+
 static inline unsigned short queue_max_segments(struct request_queue *q)
 {
 	return q->limits.max_segments;


  parent reply	other threads:[~2012-03-12  3:14 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-12  3:04 [patch 0/7] Add TRIM support for raid linear/0/1/10 Shaohua Li
2012-03-12  3:04 ` [patch 1/7] block: makes bio_split support bio without data Shaohua Li
2012-03-12  3:04 ` [patch 2/7] md: linear supports TRIM Shaohua Li
2012-03-12  3:04 ` [patch 3/7] md: raid 0 " Shaohua Li
2012-03-12  3:04 ` [patch 4/7] md: raid 1 " Shaohua Li
2012-03-12  3:04 ` [patch 5/7] md: raid 10 " Shaohua Li
2012-03-12  3:04 ` [patch 6/7] blk: add plug for blkdev_issue_discard Shaohua Li
2012-03-13 15:51   ` Vivek Goyal
2012-03-13 17:04     ` Martin K. Petersen
2012-03-13 17:14       ` Vivek Goyal
2012-03-13 17:19         ` Martin K. Petersen
2012-03-12  3:04 ` Shaohua Li [this message]
2012-03-13 16:00   ` [patch 7/7] blk: use correct sectors limitation for discard request Vivek Goyal
2012-03-12  3:18 ` [patch 0/7] Add TRIM support for raid linear/0/1/10 Roberto Spadim
2012-03-12 18:22 ` Holger Kiehl
     [not found]   ` <4F5EFEB6.4060402@kernel.org>
2012-03-13 12:22     ` Holger Kiehl
2012-03-13 14:15       ` Shaohua Li
2012-03-13 14:58         ` Roberto Spadim
2012-03-13 15:44         ` Holger Kiehl
2012-03-14  1:30           ` Shaohua Li
2012-03-14 10:25             ` Holger Kiehl
2012-03-14 11:14               ` Shaohua Li
2012-03-14 11:32                 ` Shaohua Li
2012-03-14 21:01                   ` Holger Kiehl
2012-03-14 21:13                 ` Holger Kiehl
2012-03-15  2:39                   ` Shaohua Li
2012-03-15  9:08                     ` Holger Kiehl
2012-03-16  2:19                       ` Shaohua Li
     [not found]   ` <4F5EA8E9.5010502@fusionio.com>
2012-03-14  2:25     ` NeilBrown
2012-03-14  2:24 ` NeilBrown
2012-03-14  2:47   ` Shaohua Li
2012-03-17 18:14     ` Mark Lord
2012-03-18  2:03       ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312031306.030156009@fusionio.com \
    --to=shli@fusionio.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox