From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754790Ab2CLOVc (ORCPT ); Mon, 12 Mar 2012 10:21:32 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:44947 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751662Ab2CLOV3 (ORCPT ); Mon, 12 Mar 2012 10:21:29 -0400 Date: Mon, 12 Mar 2012 14:21:26 +0000 From: Matthew Garrett To: Seth Forshee Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: Add driver for Apple gmux device Message-ID: <20120312142126.GA11969@srcf.ucam.org> References: <1329424465-1211-1-git-send-email-seth.forshee@canonical.com> <1329921457-26887-1-git-send-email-seth.forshee@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1329921457-26887-1-git-send-email-seth.forshee@canonical.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: mjg59@cavan.codon.org.uk X-SA-Exim-Scanned: No (on cavan.codon.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org apple_bl probably needs some matching work to disable itself if there's a gmux present? Otherwise, this looks good. -- Matthew Garrett | mjg59@srcf.ucam.org