public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: Add driver for Apple gmux device
Date: Mon, 12 Mar 2012 09:57:01 -0500	[thread overview]
Message-ID: <20120312145701.GA12322@ubuntu-macmini> (raw)
In-Reply-To: <20120312142126.GA11969@srcf.ucam.org>

On Mon, Mar 12, 2012 at 02:21:26PM +0000, Matthew Garrett wrote:
> apple_bl probably needs some matching work to disable itself if there's 
> a gmux present? Otherwise, this looks good.

How do you suggest doing this? The tricky point is that the gmux object
can be present in ACPI when the gmux hardware isn't really present
(which is what the version check really does, verifies the hardware is
actually there). So apple_bl can't just look for the ACPI object; it
needs to either communicate with apple-gmux or duplicate some of its
logic.

We also have the problem of gmux_backlight versus acpi_video. On most
machines with a gmux the acpi_video backlight interface is present but
just doesn't work. This problem isn't just limited to Apples. I'm of the
opinion that we need a more generalized solution for arbitrating between
the backlight interfaces present on a given machine, but I haven't had a
chance to really think about what that would look like.

Seth


  reply	other threads:[~2012-03-12 14:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 20:34 [PATCH] platform/x86: Add driver for Apple gmux device Seth Forshee
2012-02-22 14:37 ` [PATCH v2] " Seth Forshee
2012-02-29 17:46   ` Grant Likely
2012-02-29 17:53     ` Seth Forshee
2012-02-29 18:43       ` Grant Likely
2012-02-29 19:50         ` Seth Forshee
2012-02-29 21:23           ` Grant Likely
2012-02-29 22:08             ` Seth Forshee
2012-02-29 22:32               ` Grant Likely
2012-02-29 22:56                 ` Seth Forshee
2012-03-01  9:19                   ` Corentin Chary
2012-03-01 14:53                     ` Seth Forshee
2012-03-01 15:15                       ` Corentin Chary
2012-03-05 22:06   ` Seth Forshee
2012-03-05 22:10     ` Josh Boyer
2012-03-05 22:37       ` Seth Forshee
2012-03-06 12:52         ` Josh Boyer
2012-03-12 14:21   ` Matthew Garrett
2012-03-12 14:57     ` Seth Forshee [this message]
2012-03-12 15:07       ` Matthew Garrett
2012-03-12 15:18         ` Seth Forshee
2012-03-12 15:22           ` Matthew Garrett
2012-03-12 15:40             ` Seth Forshee
2012-03-15 15:47         ` Seth Forshee
2012-03-15 16:09           ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120312145701.GA12322@ubuntu-macmini \
    --to=seth.forshee@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox