From: Tejun Heo <tj@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] blk-cgroup: Call cgroup_path only under cgroup lock
Date: Mon, 12 Mar 2012 11:12:08 -0700 [thread overview]
Message-ID: <20120312181208.GD23255@google.com> (raw)
In-Reply-To: <CA+1xoqdz+m7kK+XgsmwM2Bt07eLH294L_PT6DrUkhJvRzpUZCg@mail.gmail.com>
On Mon, Mar 12, 2012 at 08:06:53PM +0200, Sasha Levin wrote:
> On Mon, Mar 12, 2012 at 8:04 PM, Tejun Heo <tj@kernel.org> wrote:
> > Hello, Sasha.
> >
> > On Mon, Mar 12, 2012 at 04:01:18PM -0400, Sasha Levin wrote:
> >> Since we can't keep rcu read lock during blkg_alloc(), we currently
> >> call cgroup_path() without any locks at all.
> >>
> >> This patch adds cgroup locking before calling cgroup_path.
> >>
> >> This also fixes a lockdep warning on boot.
> >>
> >> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> >
> > Which branch is this against? There's already pending stat update
> > patch from Vivek which fix this problem along with the percpu
> > allocation problem.
> >
> > Thanks.
>
> I've fixed it for linux-next.
Jens, the pending stats patchset should fix this problem too. Can you
please put them on top of other blkcg updates?
Thanks.
--
tejun
prev parent reply other threads:[~2012-03-12 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 20:01 [PATCH] blk-cgroup: Call cgroup_path only under cgroup lock Sasha Levin
2012-03-12 18:04 ` Tejun Heo
2012-03-12 18:06 ` Sasha Levin
2012-03-12 18:12 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120312181208.GD23255@google.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox