From: Ingo Molnar <mingo@elte.hu>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Anton Arapov <anton@redhat.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Jim Keniston <jkenisto@linux.vnet.ibm.com>,
Jiri Olsa <jolsa@redhat.com>, Josh Stone <jistone@redhat.com>
Subject: Re: [PATCH] uprobes/core: handle breakpoint and signal step exception.
Date: Tue, 13 Mar 2012 06:42:42 +0100 [thread overview]
Message-ID: <20120313054242.GA1623@elte.hu> (raw)
In-Reply-To: <20120313052016.GA27824@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> I.e. you could drop this patch altogether:
>
> x86/trivial: Fix 'old_rsp' undefined build failure when including asm/compat.h
>
> And rework the is_ia32_compat_task() patch to use another
> header and to use the is_32bit_task() name. Also, you should
> double check whether the x32 execution model needs special
> consideration as well:
>
> #define TIF_IA32 17 /* IA32 compatibility process */
> #define TIF_X32 30 /* 32-bit native x86-64 binary */
>
> otherwise uprobe will not work with x32 tasks properly.
Given that x32 tasks are using native 64-bit syscalls, what you
need is the is_ia32_task() check. We have that in -tip already,
in compat.h. If uprobes uses that definition then uprobes will
be able to probe x32 tasks as well.
To make it available to uprobes please move is_ia32_task() to
processor.h and make it return 1 on i386 kernels. This should be
a very simple patch - and that's all that is needed.
Thanks,
Ingo
next prev parent reply other threads:[~2012-03-13 5:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 11:02 [PATCH] uprobes/core: handle breakpoint and signal step exception Srikar Dronamraju
2012-02-23 12:18 ` Anton Arapov
2012-02-24 5:31 ` Srikar Dronamraju
2012-02-27 9:12 ` Ingo Molnar
2012-02-28 13:26 ` Srikar Dronamraju
2012-02-28 13:52 ` Ingo Molnar
2012-02-28 14:17 ` Srikar Dronamraju
2012-02-28 14:27 ` Ingo Molnar
2012-03-08 13:18 ` Srikar Dronamraju
2012-03-08 13:48 ` Ingo Molnar
2012-03-09 6:28 ` Srikar Dronamraju
2012-03-09 7:33 ` Ingo Molnar
2012-03-13 5:20 ` Ingo Molnar
2012-03-13 5:42 ` Ingo Molnar [this message]
2012-03-13 5:47 ` Ingo Molnar
2012-03-13 9:24 ` Srikar Dronamraju
2012-03-13 9:38 ` Ingo Molnar
2012-02-27 9:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313054242.GA1623@elte.hu \
--to=mingo@elte.hu \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jistone@redhat.com \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).