From: Joerg Roedel <joerg.roedel@amd.com>
To: KyongHo Cho <pullip.cho@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Subash Patel <subash.ramaswamy@linaro.org>,
<linux-kernel@vger.kernel.org>,
Younglak Kim <younglak1004.kim@samsung.com>,
<iommu@lists.linux-foundation.org>,
<linux-samsung-soc@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sanghyun Lee <sanghyun75.lee@samsung.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms
Date: Tue, 13 Mar 2012 11:00:24 +0100 [thread overview]
Message-ID: <20120313100024.GG18973@amd.com> (raw)
In-Reply-To: <CAHQjnOOCQb4G1aeFB0FQVBstXpaXmahnQO8+FoinPcQNZEieGg@mail.gmail.com>
On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote:
> >> +struct sysmmu_drvdata {
> >> + struct device *sysmmu;
> >> + char *dbgname;
> >> + int nsfrs;
> >> + void __iomem **sfrbases;
> >> + struct clk *clk[2];
> >> + int activations;
> >> + rwlock_t lock;
> >> + struct iommu_domain *domain;
> >> + sysmmu_fault_handler_t fault_handler;
> >> + unsigned long pgtable;
> >> + struct iommu_client client;
> >> +};
> >
> > Is there any reason why 'struct iommu_client' is a seperate data
> > structure? Otherwise it can be merged with 'truct sysmmu_drvdata'.
Of course this doesn't need to be changed immediatly. I just asked if
there was a specific reason for this seperation.
> The problems will be soon fixed and I will post next patch tomorrow.
Fine. Please also get the Acked-bys from the Exynos maintainer on
patches 1 and 2 at least. I'll merge it then.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2012-03-13 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 12:15 [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms Cho KyongHo
2012-03-12 15:01 ` Joerg Roedel
2012-03-13 8:50 ` KyongHo Cho
2012-03-13 10:00 ` Joerg Roedel [this message]
2012-03-13 16:38 ` KyongHo Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313100024.GG18973@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pullip.cho@samsung.com \
--cc=sanghyun75.lee@samsung.com \
--cc=subash.ramaswamy@linaro.org \
--cc=younglak1004.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox