From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395Ab2CMLz6 (ORCPT ); Tue, 13 Mar 2012 07:55:58 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:49375 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749Ab2CMLz4 (ORCPT ); Tue, 13 Mar 2012 07:55:56 -0400 Date: Tue, 13 Mar 2012 07:55:52 -0400 From: Christoph Hellwig To: Miklos Szeredi Cc: Christoph Hellwig , viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Trond.Myklebust@netapp.com, sfrench@samba.org, sage@newdream.net, ericvh@gmail.com Subject: Re: [PATCH 06/25] vfs: add i_op->atomic_create() Message-ID: <20120313115552.GA21043@infradead.org> References: <1331155362-11132-1-git-send-email-miklos@szeredi.hu> <1331155362-11132-7-git-send-email-miklos@szeredi.hu> <20120313093720.GC11797@infradead.org> <87lin49259.fsf@tucsk.pomaz.szeredi.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lin49259.fsf@tucsk.pomaz.szeredi.hu> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2012 at 12:22:10PM +0100, Miklos Szeredi wrote: > Good point. Yes, ->create is probably worth getting rid of. Mkdir, I'm > not so sure, but I'll look at what filesystems are doing. Btw, is there any good reason to keep ->atomic_open and ->atomic_create separate? It seems like the instances in general share code anyway.