linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [GIT PULL/NEXT] sched/arch: Introduce the finish_arch_post_lock_switch() scheduler callback
Date: Tue, 13 Mar 2012 13:10:34 +0100	[thread overview]
Message-ID: <20120313121034.GA15543@elte.hu> (raw)
In-Reply-To: <20120313115640.GA27378@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> [...]
> 
> Having a patch applied to an old scheduler tree that is barely 
> out of -rc1 and then pushing it out into linux-next at -rc8, 
> without even checking how it integrates with upstream, barely 
> a few days before the merge window is just plain stupid.

So, while I cannot know what Linus will think and do once he 
gets such a conflict (my guess is that he'd just fix it up 
silently - it's really trivial), I can tell you what the 
conflict told *me*: that the communication channels between the 
ARM tree and the scheduler tree are not in the best of shape.

And that is what worried me enough to write a reply while 
recognizing that PeterZ acked the patch - not the triviality of 
the patch or the triviality of the conflict.

And dammit, I have the right and the duty to be concerned about 
a conflict in the scheduler code if I see it for the first time, 
not just Linus. Conflicts aren't magically just for Linus to be 
interested and act upon, they can occasionally be informative at 
subsystem maintainer levels just as well - like here...

What we should not do in terms of conflict avoidance are 
*excessive* cross-subsystem merges: for example you 
indiscriminately merging the totality of all pending scheduler 
changes into the ARM tree and thus forcing Linus's hand in terms 
of not being able to reject to pull the scheduler tree.

But if I got it right, working together on a trivial, 
well-isolated callback patch to make life easier is not frowned 
upon by Linus at all ...

Thanks,

	Ingo

  parent reply	other threads:[~2012-03-13 12:11 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13  0:08 linux-next: manual merge of the arm tree with Linus' tree Stephen Rothwell
2012-03-13  6:16 ` Ingo Molnar
2012-03-13  8:33   ` Russell King
2012-03-13  8:36     ` Ingo Molnar
2012-03-13  8:47       ` Russell King
2012-03-13  8:56         ` Ingo Molnar
2012-03-13  9:00           ` Russell King
2012-03-13  9:26             ` [GIT PULL/NEXT] sched/arch: Introduce the finish_arch_post_lock_switch() scheduler callback Ingo Molnar
2012-03-13  9:50               ` Russell King
2012-03-13 10:19                 ` Ingo Molnar
2012-03-13 11:27                   ` Russell King
2012-03-13 11:56                     ` Ingo Molnar
2012-03-13 12:00                       ` Russell King
2012-03-13 12:20                         ` Ingo Molnar
2012-03-13 12:36                           ` Russell King
2012-03-13 13:02                             ` Ingo Molnar
2012-03-13 12:10                       ` Ingo Molnar [this message]
2012-03-13 12:17                       ` Russell King
2012-03-13 12:44                         ` Ingo Molnar
2012-03-13 13:04                           ` Russell King
2012-03-13 13:31                             ` Ingo Molnar
2012-03-13 15:47                               ` Ingo Molnar
2012-03-30 13:52                                 ` Catalin Marinas
2012-03-30 14:25                                   ` Ingo Molnar
2012-03-30 17:21                                     ` Catalin Marinas
2012-03-13 11:11               ` Catalin Marinas
2012-03-13  8:48     ` linux-next: manual merge of the arm tree with Linus' tree Ingo Molnar
2012-03-13  8:58       ` Russell King
2012-03-13  9:06         ` Ingo Molnar
2012-03-13  9:09           ` Russell King
2012-03-13  9:11           ` Russell King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120313121034.GA15543@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).