From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758375Ab2CMWK7 (ORCPT ); Tue, 13 Mar 2012 18:10:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49666 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585Ab2CMWK6 (ORCPT ); Tue, 13 Mar 2012 18:10:58 -0400 Date: Tue, 13 Mar 2012 15:10:49 -0700 From: Andrew Morton To: Daniel Walker Cc: Avery Pennarun , Josh Triplett , "Paul E. McKenney" , Ingo Molnar , "David S. Miller" , Peter Zijlstra , "Fabio M. Di Nitto" , Johannes Weiner , Olaf Hering , Paul Gortmaker , Tejun Heo , "H. Peter Anvin" , Yinghai LU , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/5] Persist printk buffer across reboots. Message-Id: <20120313151049.fa33d232.akpm@linux-foundation.org> In-Reply-To: <20120313170851.GA5218@fifo99.com> References: <1331617001-20906-1-git-send-email-apenwarr@gmail.com> <20120313170851.GA5218@fifo99.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2012 10:08:51 -0700 Daniel Walker wrote: > On Tue, Mar 13, 2012 at 01:36:36AM -0400, Avery Pennarun wrote: > > The last patch in this series implements a new CONFIG_PRINTK_PERSIST option > > that, when enabled, puts the printk buffer in a well-defined memory location > > so that we can keep appending to it after a reboot. The upshot is that, > > even after a kernel panic or non-panic hard lockup, on the next boot > > userspace will be able to grab the kernel messages leading up to it. It > > could then upload the messages to a server (for example) to keep crash > > statistics. > > There's currently driver/mtd/mtdoops.c, fs/pstore/, and > drivers/staging/android/ram_console.c that do similar things > as this. Did you investigate those for potentially modifying them to add > this functionality ? If so what issues did you find? > > I have a arm MSM G1 with persistent memory at 0x16d00000 size 20000bytes.. > It's fairly simple you just have to ioremap the memory, but then it's good > for writing.. Currently the android ram_console uses this. How would I > convert this area for use with your changes? Yes, and various local implementations which do things such as stuffing the log buffer into NVRAM as the kernel is crashing. I do think we'd need some back-end driver arrangement which will permit the use of stores which aren't in addressible mamory. It's quite the can of worms, but definitely worth doing if we can get it approximately correct.