From: Greg KH <gregkh@linuxfoundation.org>
To: Ben Guthro <ben@guthro.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: 3.2.10 stable build failures?
Date: Tue, 13 Mar 2012 09:35:51 -0700 [thread overview]
Message-ID: <20120313163551.GA3875@kroah.com> (raw)
In-Reply-To: <CAOvdn6W+-w2wYdqLCMHUDJr0WDXn3ssBvWnvvZy7Ni_FG2C0jQ@mail.gmail.com>
On Tue, Mar 13, 2012 at 09:25:03AM -0400, Ben Guthro wrote:
> Hello - I merged the 3.2.10 stable patch set that you pushed yesterday
> into my tree, but am seeing build failures that
> WM1811_JACKDET_MODE_MASK is undeclared.
>
> This looks like it originated with the following commit:
>
> commit 315e73b400c9a287a53efb5f857d308589674ac5
> Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Date: Mon Feb 20 21:32:32 2012 +0000
>
> mfd: Test for jack detection when deciding if wm8994 should suspend
>
> commit e7c248a049c2aac21bded0b0722caee6f0e57256 upstream.
>
> The jack detection on WM1811 is often required during system suspend, add
> it as another check when deciding if we should suspend.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
>
> I've grepped the entire 3.2.10 source tree for
> WM1811_JACKDET_MODE_MASK - but have only found the occurence in the if
> statement introduced in the above changeset
Ugh, you are right, thanks for pointing it out to me. My .config I test
with here didn't have that driver enabled, my appologies.
I'll go do a new release right now, reverting this patch.
Mark, if you want this patch in 3.2, please rework it and resend it to
me.
thanks,
greg k-h
prev parent reply other threads:[~2012-03-13 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 13:25 3.2.10 stable build failures? Ben Guthro
2012-03-13 16:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120313163551.GA3875@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ben@guthro.net \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox