From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758493Ab2CMROb (ORCPT ); Tue, 13 Mar 2012 13:14:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758399Ab2CMROa (ORCPT ); Tue, 13 Mar 2012 13:14:30 -0400 Date: Tue, 13 Mar 2012 13:14:14 -0400 From: Vivek Goyal To: "Martin K. Petersen" Cc: Shaohua Li , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, neilb@suse.de, axboe@kernel.dk Subject: Re: [patch 6/7] blk: add plug for blkdev_issue_discard Message-ID: <20120313171414.GJ29169@redhat.com> References: <20120312030412.375458948@fusionio.com> <20120312031305.946211513@fusionio.com> <20120313155120.GG29169@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2012 at 01:04:58PM -0400, Martin K. Petersen wrote: > >>>>> "Vivek" == Vivek Goyal writes: > > Vivek> On Mon, Mar 12, 2012 at 11:04:18AM +0800, Shaohua Li wrote: > >> In raid 0 case, a big discard request is divided into several small > >> requests in chunk_size unit. Such requests can be merged in low layer > >> if we have correct plug added. This should improve the performance a > >> little bit. > > Vivek> Martin posted a patch to remove the support for allowing merging > Vivek> of discard requests. But this seems to be a reasonable use case > Vivek> for allowing mering discard requests. CCing Martin. > > Merging discard requests is hard given how we need to prepare the > command payload at the bottom of the stack. The current upstream merge > code pretends to be working but it actually doesn't. That's why I want > it dead and buried. > > I have some changes pending (that I need for the REQ_COPY support) that > will make merging of non-rw requests easier to deal with. But that's a > kernel release cycle away... So first we will get rid of mering discard request and then enable after one release cycle once REQ_COPY support is in? Thanks Vivek