From: Anton Vorontsov <anton.vorontsov@linaro.org>
To: Arun Murthy <arun.murthy@stericsson.com>
Cc: dwmw2@infradead.org, linux-kernel@vger.kernel.org,
karl.komierowski@stericsson.com, johan.palsson@stericsson.com,
linus.walleij@linaro.org
Subject: [PATCH 6/6] ab8500: Turn unneeded global symbols into local ones
Date: Wed, 14 Mar 2012 05:05:25 +0400 [thread overview]
Message-ID: <20120314010525.GF10798@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <20120314005901.GB1778@oksana.dev.rtsoft.ru>
The patch fixes the following sparse warning:
drivers/power/ab8500_charger.c:1619:6: warning: symbol 'ab8500_charger_detect_usb_type_work' was not declared. Should it be static?
drivers/power/abx500_chargalg.c:1709:24: warning: symbol 'abx500_chargalg_sysfs_ops' was not declared. Should it be static?
drivers/power/ab8500_fg.c:2328:24: warning: symbol 'ab8500_fg_sysfs_ops' was not declared. Should it be static?
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---
drivers/power/ab8500_charger.c | 2 +-
drivers/power/ab8500_fg.c | 2 +-
drivers/power/abx500_chargalg.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c
index a7217d6..e2b4acc 100644
--- a/drivers/power/ab8500_charger.c
+++ b/drivers/power/ab8500_charger.c
@@ -1616,7 +1616,7 @@ static void ab8500_charger_ac_work(struct work_struct *work)
*
* Detect the type of USB plugged
*/
-void ab8500_charger_detect_usb_type_work(struct work_struct *work)
+static void ab8500_charger_detect_usb_type_work(struct work_struct *work)
{
int ret;
diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index 0441f9d..eaf149e 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -2325,7 +2325,7 @@ ab8500_fg_store(struct kobject *kobj, struct attribute *attr, const char *buf,
return entry->store(di, buf, count);
}
-const struct sysfs_ops ab8500_fg_sysfs_ops = {
+static const struct sysfs_ops ab8500_fg_sysfs_ops = {
.show = ab8500_fg_show,
.store = ab8500_fg_store,
};
diff --git a/drivers/power/abx500_chargalg.c b/drivers/power/abx500_chargalg.c
index fbb6a1f..804b88c 100644
--- a/drivers/power/abx500_chargalg.c
+++ b/drivers/power/abx500_chargalg.c
@@ -1706,7 +1706,7 @@ static struct attribute *abx500_chargalg_chg[] = {
NULL
};
-const struct sysfs_ops abx500_chargalg_sysfs_ops = {
+static const struct sysfs_ops abx500_chargalg_sysfs_ops = {
.store = abx500_chargalg_sysfs_charger,
};
--
1.7.9
next prev parent reply other threads:[~2012-03-14 1:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 16:24 [PATCH 0/4] AB8500 Battery Management Driver Arun Murthy
2012-02-29 16:24 ` [PATCH 1/4] power: abx500-chargalg: Add abx500 charging algorithm Arun Murthy
2012-02-29 16:24 ` [PATCH 2/4] power: ab8500-charger: AB8500 charger driver Arun Murthy
2012-02-29 17:50 ` Andi
2012-02-29 18:21 ` Arun Murthy
2012-02-29 16:24 ` [PATCH 3/4] power: ab8500-fg: A8500 fuel gauge driver Arun Murthy
2012-02-29 16:24 ` [PATCH 4/4] power: ab8500-btemp: AB8500 battery temperature driver Arun Murthy
2012-03-14 0:59 ` [PATCH 0/4] AB8500 Battery Management Driver Anton Vorontsov
2012-03-14 1:04 ` [PATCH 1/6] ab8500_charger: Convert to the new USB OTG calls Anton Vorontsov
2012-03-14 4:03 ` Arun MURTHY
2012-03-14 1:05 ` [PATCH 2/6] ab8500_btemp: Get rid of 'enum adc_therm' Anton Vorontsov
2012-03-14 4:25 ` Arun MURTHY
2012-03-14 1:05 ` [PATCH 3/6] ab8500_fg: Get rid of 'struct v_to_cap' Anton Vorontsov
2012-03-14 4:36 ` Arun MURTHY
2012-03-14 1:05 ` [PATCH 4/6] ab8500_fg: Get rid of 'struct battery_type' Anton Vorontsov
2012-03-14 4:36 ` Arun MURTHY
2012-03-14 1:05 ` [PATCH 5/6] ab8500_fg: Fix copy-paste error Anton Vorontsov
2012-03-14 4:36 ` Arun MURTHY
2012-03-14 5:45 ` Arun MURTHY
2012-03-14 1:05 ` Anton Vorontsov [this message]
2012-03-14 4:37 ` [PATCH 6/6] ab8500: Turn unneeded global symbols into local ones Arun MURTHY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314010525.GF10798@oksana.dev.rtsoft.ru \
--to=anton.vorontsov@linaro.org \
--cc=arun.murthy@stericsson.com \
--cc=dwmw2@infradead.org \
--cc=johan.palsson@stericsson.com \
--cc=karl.komierowski@stericsson.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox