From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030417Ab2CNCTn (ORCPT ); Tue, 13 Mar 2012 22:19:43 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:46749 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030384Ab2CNCTl (ORCPT ); Tue, 13 Mar 2012 22:19:41 -0400 Date: Tue, 13 Mar 2012 22:19:38 -0400 From: "Ted Ts'o" To: Joe Perches Cc: Andrew Morton , Andy Whitcroft , LKML Subject: Re: [PATCH] checkpatch: Suggest pr_ over printk(KERN_ Message-ID: <20120314021938.GD15379@thunk.org> Mail-Followup-To: Ted Ts'o , Joe Perches , Andrew Morton , Andy Whitcroft , LKML References: <1330667673.1939.22.camel@joe2Laptop> <1331619783.7100.8.camel@joe2Laptop> <20120313120514.GA17538@thunk.org> <20120313145517.f4fcae46.akpm@linux-foundation.org> <20120313220144.GD11969@thunk.org> <20120313150316.6ae19b95.akpm@linux-foundation.org> <20120314003157.GA15379@thunk.org> <1331686026.24613.6.camel@joe2Laptop> <20120314010701.GB15379@thunk.org> <1331687831.27389.2.camel@joe2Laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1331687831.27389.2.camel@joe2Laptop> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on test.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2012 at 06:17:11PM -0700, Joe Perches wrote: > The patch was all apiece, every bit associated to logging output. > It was bundled to make it easier to apply. > > You call it junk, I call it cleanups. Changing stuff to pr_foo is ***NOISE***. It adds no value, and it makes it my life much, MUCH harder. Andrew, please, can we NACK this pr_foo checkpatch.pl change? - Ted