From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Miller <amiller@amilx.com>
Cc: Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue
Date: Tue, 13 Mar 2012 19:54:02 -0700 [thread overview]
Message-ID: <20120314025402.GD22955@kroah.com> (raw)
In-Reply-To: <20120314023342.GC7156@iron>
On Tue, Mar 13, 2012 at 10:33:42PM -0400, Andrew Miller wrote:
> Thanks, you help me alot
>
> If you don't mind me asking a few more question.
>
> Would fixing things like this
>
> - if(x==y)
> + if(x == y)
>
> be worthless?
Yes, as it should really be:
if (x == y)
:)
> Changing c++ style comment to c style?
That's also good.
> And I should not wory about line being longer the 80 charactor, unless they are
> just extremely long?
If you feel it will read better, than yes, do it.
> I'm just over half way through my CS degree, so I'm a complete noob.
> I'm still learning what is not worth spending time on and what is.
This is worthwhile, if you want to do this. Cleanups like this are a
great place to learn and get involved and become comfortable with the
codebase.
Just don't mix different fixes in the same patch.
And don't top post :)
thanks,
greg k-h
next prev parent reply other threads:[~2012-03-14 2:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 0:58 [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue Andrew Miller
2012-03-14 1:33 ` Joe Perches
2012-03-14 1:49 ` Andrew Miller
2012-03-14 2:12 ` Joe Perches
2012-03-14 2:33 ` Andrew Miller
2012-03-14 2:46 ` Joe Perches
2012-03-14 3:09 ` Larry Finger
2012-03-14 2:54 ` Greg KH [this message]
2012-03-14 4:18 ` Ryan Mallon
2012-03-14 4:49 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2012-03-11 4:32 Andrew Miller
2012-03-13 22:42 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314025402.GD22955@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amiller@amilx.com \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox