Re: [PATCH 0/6] Add a per-dimm structure

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 14, 2012 at 11:31:02PM +0100, Borislav Petkov wrote:
> On Wed, Mar 14, 2012 at 01:43:55PM -0700, Greg KH wrote:
> > > He thinks that a multi-layer struct should be created inside that directory
> > > (it could have 2 or 3 levels of directories, depending on how the memory is
> > > organized at the memory controller), instead of having a large number of files
> > > there.
> > 
> > Why create subdirs?  If those subdirectories are not real devices,
> > showing a real hierarchy, then do not create them as userspace will get
> > very confused very quickly.
> 
> Why, IMO, we agreed on the following layout
> 
> rank0/
> |-- dimm_dev_type
> |-- dimm_edac_mode
> |-- dimm_label
> |-- dimm_location
> |-- dimm_mem_type
> |-- CE
> |-- UE
> `-- dimm_size
> 
> with CE being the correctable errors counter and UE be optional and only
> present when it makes sense for the hardware.
> 
> This is not multi-layered, it is very easy to implement and mirrors all
> possible memory controllers from the point of view of the single DIMM.
> no? Or am I missing something...?

Looks fine to me, assuming "rankX" is the dimm itself?

greg k-h