* [PATCH] edac: i5100 fix erroneous define for M1Err
@ 2012-02-17 10:36 Niklas Söderlund
2012-03-15 17:19 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2012-02-17 10:36 UTC (permalink / raw)
To: lucas.demarchi, borislav.petkov, linux-edac
Cc: linux-kernel, thang.b.nguyen, Niklas Söderlund
According to [1] the define for M1Err in the FERR_NF_MEM register is
wrong. It should be at position 1 not 0.
[1] Intel 5100 Memory Controller Hub Chipset Doc.Nr: 318378
http://www.intel.com/content/dam/doc/datasheet/5100-
memory-controller-hub-chipset-datasheet.pdf
Reported-by: Ba Thang Nguyen <thang.b.nguyen@dektech.com.au>
Signed-off-by: Niklas Söderlund <niklas.soderlund@ericsson.com>
---
drivers/edac/i5100_edac.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
index bcbdeec..ab2f906 100644
--- a/drivers/edac/i5100_edac.c
+++ b/drivers/edac/i5100_edac.c
@@ -49,7 +49,7 @@
#define I5100_FERR_NF_MEM_M6ERR_MASK (1 << 6)
#define I5100_FERR_NF_MEM_M5ERR_MASK (1 << 5)
#define I5100_FERR_NF_MEM_M4ERR_MASK (1 << 4)
-#define I5100_FERR_NF_MEM_M1ERR_MASK 1
+#define I5100_FERR_NF_MEM_M1ERR_MASK (1 << 1)
#define I5100_FERR_NF_MEM_ANY_MASK \
(I5100_FERR_NF_MEM_M16ERR_MASK | \
I5100_FERR_NF_MEM_M15ERR_MASK | \
--
1.7.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] edac: i5100 fix erroneous define for M1Err
2012-02-17 10:36 [PATCH] edac: i5100 fix erroneous define for M1Err Niklas Söderlund
@ 2012-03-15 17:19 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2012-03-15 17:19 UTC (permalink / raw)
To: Niklas Söderlund
Cc: lucas.demarchi, borislav.petkov, linux-edac, linux-kernel,
thang.b.nguyen
Em Fri, 17 Feb 2012 11:36:54 +0100
Niklas Söderlund <niklas.soderlund@ericsson.com> escreveu:
> According to [1] the define for M1Err in the FERR_NF_MEM register is
> wrong. It should be at position 1 not 0.
>
> [1] Intel 5100 Memory Controller Hub Chipset Doc.Nr: 318378
> http://www.intel.com/content/dam/doc/datasheet/5100-
> memory-controller-hub-chipset-datasheet.pdf
>
> Reported-by: Ba Thang Nguyen <thang.b.nguyen@dektech.com.au>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@ericsson.com>
> ---
> drivers/edac/i5100_edac.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index bcbdeec..ab2f906 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -49,7 +49,7 @@
> #define I5100_FERR_NF_MEM_M6ERR_MASK (1 << 6)
> #define I5100_FERR_NF_MEM_M5ERR_MASK (1 << 5)
> #define I5100_FERR_NF_MEM_M4ERR_MASK (1 << 4)
> -#define I5100_FERR_NF_MEM_M1ERR_MASK 1
> +#define I5100_FERR_NF_MEM_M1ERR_MASK (1 << 1)
> #define I5100_FERR_NF_MEM_ANY_MASK \
> (I5100_FERR_NF_MEM_M16ERR_MASK | \
> I5100_FERR_NF_MEM_M15ERR_MASK | \
Looks fine. I'm applying on my edac -next tree, together with the other fix:
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac.git linux-next
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-15 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 10:36 [PATCH] edac: i5100 fix erroneous define for M1Err Niklas Söderlund
2012-03-15 17:19 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox