From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Simon Horman <horms@verge.net.au>
Cc: Liam Girdwood <lrg@ti.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: notify sysfs when voltage is set
Date: Thu, 15 Mar 2012 14:47:08 +0000 [thread overview]
Message-ID: <20120315144708.GM3138@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120315142657.GD3129@verge.net.au>
[-- Attachment #1: Type: text/plain, Size: 1457 bytes --]
On Thu, Mar 15, 2012 at 11:26:58PM +0900, Simon Horman wrote:
> On Thu, Mar 15, 2012 at 12:46:31PM +0000, Mark Brown wrote:
> > I notice that we don't generate similar events for cpufreq... what are
> > the performance implications from firing off udev (which isn't free)
> > every time we scale the CPU frequency? It feels like this might be
> > disruptive, especially with a governor like ondemand which responds to
> > system load.
> that is a good point and to be honest not one that I had considered. For
> the use-case that I have in mind, which is basically to log voltage changes
> over time, it may be acceptable to rate-limit notifications somehow. But at
> that point I may be better off just polling.
Hrm, if you're doing logging then we do already have tracepoints defined
for voltage changes - could you have your application work with those
instead of sysfs? One of the applications of tracepoints is flight
recorder style system monitoring.
> Out of interest, how often can ondemand potentially change the voltage?
Depends on how slow it thinks frequency changes are. I'm not so worried
about the performance impact from that point of view, I'm more worried
about what happens when we lower the clock frequency and generate a
sysfs event causing userspace to wake up and start doing stuff. It'd be
bad if ondemand (or another dynamic governor) noticed that the system
got more busy again and responded by ramping the frequency...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-15 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 12:04 [PATCH] regulator: notify sysfs when voltage is set Simon Horman
2012-03-15 12:46 ` Mark Brown
2012-03-15 14:26 ` Simon Horman
2012-03-15 14:47 ` Mark Brown [this message]
2012-03-15 23:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315144708.GM3138@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox