public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] platform/x86: Add driver for Apple gmux device
Date: Thu, 15 Mar 2012 16:09:03 +0000	[thread overview]
Message-ID: <20120315160903.GA7502@srcf.ucam.org> (raw)
In-Reply-To: <20120315154756.GE9673@ubuntu-macmini>

On Thu, Mar 15, 2012 at 10:47:56AM -0500, Seth Forshee wrote:

> Turns out that acpi_video0 does work under Windows, and it also works
> under Linux depending on how the OS is booted. Doing a boot camp style
> boot gives us working acpi_video0 and apple_bl backlights. acpi_video1
> doesn't show up in a legacy boot situation, as evaluating _BCM gives an
> error.
> 
> Under EFI boot, both acpi_video backlights show up but neither works.
> The readback verify in apple_bl's probe fails, so that one doesn't show
> up. Only gmux_backlight actually works.

Ok, that's consistent. You can probably handle that case by just calling 
acpi_video_unregister() in gmux. Something like your patch looks fine 
for the apple_bl case.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

      reply	other threads:[~2012-03-15 16:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 20:34 [PATCH] platform/x86: Add driver for Apple gmux device Seth Forshee
2012-02-22 14:37 ` [PATCH v2] " Seth Forshee
2012-02-29 17:46   ` Grant Likely
2012-02-29 17:53     ` Seth Forshee
2012-02-29 18:43       ` Grant Likely
2012-02-29 19:50         ` Seth Forshee
2012-02-29 21:23           ` Grant Likely
2012-02-29 22:08             ` Seth Forshee
2012-02-29 22:32               ` Grant Likely
2012-02-29 22:56                 ` Seth Forshee
2012-03-01  9:19                   ` Corentin Chary
2012-03-01 14:53                     ` Seth Forshee
2012-03-01 15:15                       ` Corentin Chary
2012-03-05 22:06   ` Seth Forshee
2012-03-05 22:10     ` Josh Boyer
2012-03-05 22:37       ` Seth Forshee
2012-03-06 12:52         ` Josh Boyer
2012-03-12 14:21   ` Matthew Garrett
2012-03-12 14:57     ` Seth Forshee
2012-03-12 15:07       ` Matthew Garrett
2012-03-12 15:18         ` Seth Forshee
2012-03-12 15:22           ` Matthew Garrett
2012-03-12 15:40             ` Seth Forshee
2012-03-15 15:47         ` Seth Forshee
2012-03-15 16:09           ` Matthew Garrett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120315160903.GA7502@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox