From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759372Ab2COR5J (ORCPT ); Thu, 15 Mar 2012 13:57:09 -0400 Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:52596 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755998Ab2COR5F (ORCPT ); Thu, 15 Mar 2012 13:57:05 -0400 Date: Thu, 15 Mar 2012 18:57:01 +0100 From: Sebastian Andrzej Siewior To: Pete Zaitcev Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb/ub: deprecate & schedule for removal the "Low Performance USB Block" driver Message-ID: <20120315175701.GA5702@breakpoint.cc> References: <1331758372-9851-1-git-send-email-sebastian@breakpoint.cc> <20120315093331.6472333e@lembas.zaitcev.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120315093331.6472333e@lembas.zaitcev.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 15, 2012 at 09:33:31AM -0600, Pete Zaitcev wrote: > On Wed, 14 Mar 2012 21:52:51 +0100 > Sebastian Andrzej Siewior wrote: > > > +What: Low Performance USB Block driver ("CONFIG_BLK_DEV_UB") > > +When: 3.6 > > ACK > > > + does not use libusual which holds various workarounds for > > + certain buggy devices. > > Although the above is false, and ub actually started libusual, > I don't mind. It's a transient notice anyway. Once ub is gone, > libusual can be folded back into usb-storage. There might be an miss understanding here. For instance in drivers/usb/storage/unusual_devs.h we have an entry like: |UNUSUAL_DEV( 0x03f0, 0x4002, 0x0001, 0x0001, | "HP", | "PhotoSmart R707", | USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_FIX_CAPACITY), | That US_FL_FIX_CAPACITY is used later in scsiglue.c to set sdev->fix_capacity which is then used by sd_read_capacity() to substract one sector from the final size. In ub I see ub_sync_read_cap() and I don't see a change. Was my wording wrong or is this something else? > -- Pete Sebastian