From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Alexandra Sava <alexandrasava18@gmail.com>
Cc: "Savoy, Pavan" <pavan_savoy@ti.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
"mgherzan@gmail.com" <mgherzan@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver
Date: Thu, 15 Mar 2012 14:23:38 -0700 [thread overview]
Message-ID: <20120315212338.GA22983@kroah.com> (raw)
In-Reply-To: <CAMFpKOjphDX0HbaReZCNHtux=j1LSpEK6nU3thddqFUHXUCiuA@mail.gmail.com>
On Thu, Mar 15, 2012 at 11:17:25PM +0200, Alexandra Sava wrote:
> On 15 March 2012 23:10, Alexandra Sava <alexandrasava18@gmail.com> wrote:
> > On 15 March 2012 22:29, Savoy, Pavan <pavan_savoy@ti.com> wrote:
> >> Daniel Baluta wrote:
> >>> Adding Greg's new email address.
> >>>
> >>> On Thu, Mar 15, 2012 at 8:26 PM, <alexandrasava18@gmail.com> wrote:
> >>>> From: Alexandra Sava <alexandrasava18@gmail.com>
> >>>>
> >>>> * added new module parameter named debug_mask to control displayed
> >>>> messages verbosity
> >>>> * the logging mechanism is enabled via CONFIG_TI_ST_DEBUG Kconfig
> >>>> option
> >>
> >> Any specific reason you want to have this ? Custom logging ?
> >> Also please fix the spelling in the subject line.
> >>
> >
> > The logging for this driver is too verbose, and I thought it would be
> > better to implement a configurable mechanism which can enable/disable
> > the log messages (not only via the global CONFIG_DYNAMIC_DEBUG).
> > So, I think there are two ways:
>
> The logging for this driver is too verbose, and I thought it would be
> better to implement a configurable mechanism which can enable/disable
> the log messages (not only via the global CONFIG_DYNAMIC_DEBUG).
> So, I think there are two ways:
> 1. keep pr_debug but reduce the amount of messages
That's probably the best, you aren't needing almost all of them anymore
now that the driver is working.
> 2. make the logs configurabile via CONFIG_TI_SI_DEBUG
No, don't do this, no one will enable it.
greg k-h
next prev parent reply other threads:[~2012-03-15 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 18:26 [PATCH] ti-st: Enhange logging for Shared Transport - TI driver alexandrasava18
2012-03-15 20:17 ` Daniel Baluta
2012-03-15 20:29 ` Savoy, Pavan
2012-03-15 21:10 ` Alexandra Sava
2012-03-15 21:17 ` Alexandra Sava
2012-03-15 21:23 ` gregkh [this message]
2012-03-16 0:30 ` Mircea Gherzan
2012-03-16 0:35 ` Greg KH
2012-03-16 0:41 ` Joe Perches
2012-03-16 0:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315212338.GA22983@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandrasava18@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgherzan@gmail.com \
--cc=pavan_savoy@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox