From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032524Ab2CPAf1 (ORCPT ); Thu, 15 Mar 2012 20:35:27 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:62577 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032487Ab2CPAf0 (ORCPT ); Thu, 15 Mar 2012 20:35:26 -0400 Date: Thu, 15 Mar 2012 17:35:23 -0700 From: Greg KH To: Mircea Gherzan Cc: alexandrasava18@gmail.com, pavan_savoy@ti.com, daniel.baluta@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver Message-ID: <20120316003523.GA25149@kroah.com> References: <4f623469.634cb40a.5d79.ffff841d@mx.google.com> <4F6289B3.2060204@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F6289B3.2060204@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 16, 2012 at 01:30:43AM +0100, Mircea Gherzan wrote: > > This is what I get now (with no debug) when loading the btwilink module > that uses ti-st: > > [ 129.567382] (stk) :change remote baud rate command in firmware > [ 129.573577] (stk) :skipping the wait event of change remote baud > > This is: > 1. too "verbose" => these 2 prints should belong to debug > 2. poorly formated > 3. not telling me which driver generated this output > 4. not giving me the version of the firmware that was loaded. > > To address 2 and 3, please remove the the "(stc)" / "(stk)" prefixes and > use instead the quite widespread prefix KBUILD_MODNAME ": " No, just use the proper dev_*() functions instead, it will tell you exactly what driver and device emitted the message, that is what it is there for. thanks, greg k-h