From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: linux-next: manual merge of the arm-soc tree with the s5p tree
Date: Fri, 16 Mar 2012 08:26:36 +0000 [thread overview]
Message-ID: <201203160826.36287.arnd@arndb.de> (raw)
In-Reply-To: <20120316174546.5121be30a86c2937579bd3f5@canb.auug.org.au>
On Friday 16 March 2012, Stephen Rothwell wrote:
> Today's linux-next merge of the arm-soc tree got a conflict in
> arch/arm/mach-exynos/common.c between commit 1d7233ac478a ("Merge branch
> 'next/soc-exynos5250-arch-gpio' into for-next") from the s5p tree and
> commit 853a0231e057 ("Merge branch 'samsung/soc' into next/soc2") from
> the arm-soc tree.
>
> These merge commits both looks suspect, but I fixed it up as best I could
> (see below).
Right, both the arm-soc and the s5p tree merge the same commits and
come to different results. Kgene, please have a look and let me know
which of the three solutions is correct.
Arnd
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
>
> diff --cc arch/arm/mach-exynos/common.c
> index 4e1d0b7,e6cc50e..0000000
> --- a/arch/arm/mach-exynos/common.c
> +++ b/arch/arm/mach-exynos/common.c
> @@@ -593,6 -586,14 +593,13 @@@ static int __init exynos4_l2x0_cache_in
> if (soc_is_exynos5250())
> return 0;
>
> - int ret;
> + ret = l2x0_of_init(L2_AUX_VAL, L2_AUX_MASK);
> + if (!ret) {
> + l2x0_regs_phys = virt_to_phys(&l2x0_saved_regs);
> + clean_dcache_area(&l2x0_regs_phys, sizeof(unsigned long));
> + return 0;
> + }
> +
> if (!(__raw_readl(S5P_VA_L2CC + L2X0_CTRL) & 0x1)) {
> l2x0_saved_regs.phy_base = EXYNOS4_PA_L2CC;
> /* TAG, Data Latency Control: 2 cycles */
next prev parent reply other threads:[~2012-03-16 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-16 6:45 linux-next: manual merge of the arm-soc tree with the s5p tree Stephen Rothwell
2012-03-16 8:26 ` Arnd Bergmann [this message]
2012-03-16 10:00 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203160826.36287.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox