From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501Ab2CPRkT (ORCPT ); Fri, 16 Mar 2012 13:40:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:58107 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753397Ab2CPRkJ (ORCPT ); Fri, 16 Mar 2012 13:40:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="121736334" Date: Fri, 16 Mar 2012 18:48:02 +0100 From: Samuel Ortiz To: Dmitry Torokhov Cc: Chanwoo Choi , linux-input@vger.kernel.org, broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, myungjoo.ham@samsung.com Subject: Re: [PATCH v3 2/2] input: add driver support for MAX8997-haptic Message-ID: <20120316174802.GI20524@sortiz-mobl> References: <4F5DB459.9090701@samsung.com> <20120314084652.GC3964@core.coreip.homeip.net> <4F60AF8E.7050900@samsung.com> <20120314154828.GA24964@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120314154828.GA24964@core.coreip.homeip.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dmitry, On Wed, Mar 14, 2012 at 08:48:28AM -0700, Dmitry Torokhov wrote: > On Wed, Mar 14, 2012 at 11:47:42PM +0900, Chanwoo Choi wrote: > > Hi Dmitry, > > > > > This is not proper locking between playing effect and suspend. Now that > > > you are using workqueue you need to synchronize access with it, not with > > > play_effect method. > > > > > > Does the following patch work for you? > > > > > > > Your patch is worked on TRATS board based on EXYNOS4210 but, you should > > apply following patch because 'chip->enabled' is used on > > max8997_haptic_configure() function to enable/disable haptic motor. > > OK, excellent. I'll pick up this fix and apply the driver for 3.4 queue, > thanks! Your patch depends on the MFD changes Choi sent along the input driver. I think it would make more sense for me to take it. What do you think ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/