* [PATCH] mfd: Fix compilation error in TPS65910.h
@ 2012-03-16 7:28 Venu Byravarasu
2012-03-16 19:02 ` Mark Brown
2012-03-16 20:01 ` Samuel Ortiz
0 siblings, 2 replies; 6+ messages in thread
From: Venu Byravarasu @ 2012-03-16 7:28 UTC (permalink / raw)
To: sameo, linux-kernel, jedu, lrg, broonie, gg; +Cc: Venu Byravarasu
From: Venu Byravarasu <vbyravarasu@nvidia.com>
Fix compilation error due to including TPS65910.h
'struct gpio_chip' is declared in include/asm-generic/gpio.h
which is included by include/linux/gpio.h.
However without including gpio.h, TPS65910.h declares
a member of this type as part of 'struct tps65910' declaration.
This causes compilation error, if gpio.h is not included
before including tps65910.h, in source files.
Hence fixing it.
Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
include/linux/mfd/tps65910.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
index 82b4c88..f226065 100644
--- a/include/linux/mfd/tps65910.h
+++ b/include/linux/mfd/tps65910.h
@@ -17,6 +17,8 @@
#ifndef __LINUX_MFD_TPS65910_H
#define __LINUX_MFD_TPS65910_H
+#include <linux/gpio.h>
+
/* TPS chip id list */
#define TPS65910 0
#define TPS65911 1
--
1.7.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: Fix compilation error in TPS65910.h
2012-03-16 7:28 [PATCH] mfd: Fix compilation error in TPS65910.h Venu Byravarasu
@ 2012-03-16 19:02 ` Mark Brown
2012-03-16 20:01 ` Samuel Ortiz
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2012-03-16 19:02 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: sameo, linux-kernel, jedu, lrg, gg
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Fri, Mar 16, 2012 at 12:58:37PM +0530, Venu Byravarasu wrote:
> From: Venu Byravarasu <vbyravarasu@nvidia.com>
>
> Fix compilation error due to including TPS65910.h
>
> 'struct gpio_chip' is declared in include/asm-generic/gpio.h
> which is included by include/linux/gpio.h.
> However without including gpio.h, TPS65910.h declares
> a member of this type as part of 'struct tps65910' declaration.
Reviwed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: Fix compilation error in TPS65910.h
2012-03-16 7:28 [PATCH] mfd: Fix compilation error in TPS65910.h Venu Byravarasu
2012-03-16 19:02 ` Mark Brown
@ 2012-03-16 20:01 ` Samuel Ortiz
2012-03-19 8:43 ` Venu Byravarasu
1 sibling, 1 reply; 6+ messages in thread
From: Samuel Ortiz @ 2012-03-16 20:01 UTC (permalink / raw)
To: Venu Byravarasu; +Cc: linux-kernel, jedu, lrg, broonie, gg
Hi Venu,
On Fri, Mar 16, 2012 at 12:58:37PM +0530, Venu Byravarasu wrote:
> From: Venu Byravarasu <vbyravarasu@nvidia.com>
>
> Fix compilation error due to including TPS65910.h
Probably too late for 3.3, but I applied this patch anyway.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mfd: Fix compilation error in TPS65910.h
2012-03-16 20:01 ` Samuel Ortiz
@ 2012-03-19 8:43 ` Venu Byravarasu
2012-03-20 10:49 ` Igor Grinberg
0 siblings, 1 reply; 6+ messages in thread
From: Venu Byravarasu @ 2012-03-19 8:43 UTC (permalink / raw)
To: Samuel Ortiz
Cc: linux-kernel@vger.kernel.org, jedu@slimlogic.co.uk,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
gg@slimlogic.co.uk
Thanks Mark and Samuel.
> -----Original Message-----
> From: Samuel Ortiz [mailto:sameo@linux.intel.com]
> Sent: Saturday, March 17, 2012 1:32 AM
> To: Venu Byravarasu
> Cc: linux-kernel@vger.kernel.org; jedu@slimlogic.co.uk; lrg@slimlogic.co.uk;
> broonie@opensource.wolfsonmicro.com; gg@slimlogic.co.uk
> Subject: Re: [PATCH] mfd: Fix compilation error in TPS65910.h
>
> Hi Venu,
>
> On Fri, Mar 16, 2012 at 12:58:37PM +0530, Venu Byravarasu wrote:
> > From: Venu Byravarasu <vbyravarasu@nvidia.com>
> >
> > Fix compilation error due to including TPS65910.h
> Probably too late for 3.3, but I applied this patch anyway.
>
> Cheers,
> Samuel.
>
> --
> Intel Open Source Technology Centre
> http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: Fix compilation error in TPS65910.h
2012-03-19 8:43 ` Venu Byravarasu
@ 2012-03-20 10:49 ` Igor Grinberg
2012-03-21 5:27 ` Venu Byravarasu
0 siblings, 1 reply; 6+ messages in thread
From: Igor Grinberg @ 2012-03-20 10:49 UTC (permalink / raw)
To: Venu Byravarasu
Cc: Samuel Ortiz, linux-kernel@vger.kernel.org, jedu@slimlogic.co.uk,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
gg@slimlogic.co.uk
On 03/19/12 10:43, Venu Byravarasu wrote:
> Thanks Mark and Samuel.
>
>> -----Original Message-----
>> From: Samuel Ortiz [mailto:sameo@linux.intel.com]
>> Sent: Saturday, March 17, 2012 1:32 AM
>> To: Venu Byravarasu
>> Cc: linux-kernel@vger.kernel.org; jedu@slimlogic.co.uk; lrg@slimlogic.co.uk;
>> broonie@opensource.wolfsonmicro.com; gg@slimlogic.co.uk
>> Subject: Re: [PATCH] mfd: Fix compilation error in TPS65910.h
>>
>> Hi Venu,
>>
>> On Fri, Mar 16, 2012 at 12:58:37PM +0530, Venu Byravarasu wrote:
>>> From: Venu Byravarasu <vbyravarasu@nvidia.com>
>>>
>>> Fix compilation error due to including TPS65910.h
>> Probably too late for 3.3, but I applied this patch anyway.
Venu,
Should this go also to stable?
If it should then, Samuel, can you please add Cc: stable@vger.kernel.org?
--
Regards,
Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] mfd: Fix compilation error in TPS65910.h
2012-03-20 10:49 ` Igor Grinberg
@ 2012-03-21 5:27 ` Venu Byravarasu
0 siblings, 0 replies; 6+ messages in thread
From: Venu Byravarasu @ 2012-03-21 5:27 UTC (permalink / raw)
To: Igor Grinberg
Cc: Samuel Ortiz, linux-kernel@vger.kernel.org, jedu@slimlogic.co.uk,
lrg@slimlogic.co.uk, broonie@opensource.wolfsonmicro.com,
gg@slimlogic.co.uk
Yes Igor, this change should get into stable as well.
> -----Original Message-----
> From: Igor Grinberg [mailto:grinberg@compulab.co.il]
> Sent: Tuesday, March 20, 2012 4:19 PM
> To: Venu Byravarasu
> Cc: Samuel Ortiz; linux-kernel@vger.kernel.org; jedu@slimlogic.co.uk;
> lrg@slimlogic.co.uk; broonie@opensource.wolfsonmicro.com;
> gg@slimlogic.co.uk
> Subject: Re: [PATCH] mfd: Fix compilation error in TPS65910.h
>
> On 03/19/12 10:43, Venu Byravarasu wrote:
> > Thanks Mark and Samuel.
> >
> >> -----Original Message-----
> >> From: Samuel Ortiz [mailto:sameo@linux.intel.com]
> >> Sent: Saturday, March 17, 2012 1:32 AM
> >> To: Venu Byravarasu
> >> Cc: linux-kernel@vger.kernel.org; jedu@slimlogic.co.uk; lrg@slimlogic.co.uk;
> >> broonie@opensource.wolfsonmicro.com; gg@slimlogic.co.uk
> >> Subject: Re: [PATCH] mfd: Fix compilation error in TPS65910.h
> >>
> >> Hi Venu,
> >>
> >> On Fri, Mar 16, 2012 at 12:58:37PM +0530, Venu Byravarasu wrote:
> >>> From: Venu Byravarasu <vbyravarasu@nvidia.com>
> >>>
> >>> Fix compilation error due to including TPS65910.h
> >> Probably too late for 3.3, but I applied this patch anyway.
>
> Venu,
> Should this go also to stable?
>
> If it should then, Samuel, can you please add Cc: stable@vger.kernel.org?
>
>
> --
> Regards,
> Igor.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-21 5:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-16 7:28 [PATCH] mfd: Fix compilation error in TPS65910.h Venu Byravarasu
2012-03-16 19:02 ` Mark Brown
2012-03-16 20:01 ` Samuel Ortiz
2012-03-19 8:43 ` Venu Byravarasu
2012-03-20 10:49 ` Igor Grinberg
2012-03-21 5:27 ` Venu Byravarasu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox