From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Pekka Enberg <penberg@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Colin Walters <walters@verbum.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] perf report: Add a simple GTK2-based 'perf report' browser
Date: Fri, 16 Mar 2012 16:48:03 -0300 [thread overview]
Message-ID: <20120316194803.GQ9528@infradead.org> (raw)
In-Reply-To: <CAOJsxLFv=Pq0iHrUQsK7gghhrmwBB=BqzY--RhisbjUZuLMEyg@mail.gmail.com>
Em Fri, Feb 24, 2012 at 12:05:56PM +0200, Pekka Enberg escreveu:
> On Fri, Feb 24, 2012 at 11:48 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > * Pekka Enberg <penberg@kernel.org> wrote:
> >
> >> On Thu, Feb 23, 2012 at 10:33 PM, Colin Walters <walters@verbum.org> wrote:
> >> >> Sure. We don't want to do that for all files. Just for the ones that
> >> >> include <gtk/gtk.h>.
> >> >
> >> > #pragma GCC diagnostic push
> >> > #pragma GCC diagnostic ignored "-Wstrict-prototypes"
> >> > #include <gtk/gtk.h>
> >> > #pragma GCC diagnostic pop
> >>
> >> It's cleaner to do it at Makefile level. We should do
> >> something like sparse.git Makefile does where you can
> >> optionally specify CFLAGS for individual source files.
> >
> > I actually like the #pragma hack because it only turns off the
> > check for that broken header and keeps our checks in place for
> > the rest of the .c file.
> >
> > Could be turned into a util/gtk.h file that is included instead
> > of <gtk/gtk.h>, so that we don't have to see the #pragma
> > workaround all the time?
>
> Sure, makes sense.
Hey,
Was there any new development here? I was going to apply, but
requiring that WERROR=0 is too ugly :-)
- Arnaldo
next prev parent reply other threads:[~2012-03-16 19:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 16:18 [PATCH] perf report: Add a simple GTK2-based 'perf report' browser Pekka Enberg
2012-02-23 16:28 ` Arnaldo Carvalho de Melo
2012-02-23 16:32 ` Pekka Enberg
2012-02-23 16:39 ` Arnaldo Carvalho de Melo
2012-02-23 16:45 ` Pekka Enberg
2012-02-23 16:47 ` Arnaldo Carvalho de Melo
2012-02-23 16:53 ` Arnaldo Carvalho de Melo
2012-02-23 17:10 ` Pekka Enberg
2012-02-23 17:37 ` Arnaldo Carvalho de Melo
2012-02-23 17:52 ` Pekka Enberg
2012-02-24 0:58 ` Namhyung Kim
2012-02-24 6:36 ` Pekka Enberg
2012-03-19 20:08 ` [tip:perf/core] " tip-bot for Pekka Enberg
2012-02-23 19:36 ` [PATCH] " Colin Walters
2012-02-23 20:18 ` Pekka Enberg
2012-02-23 20:33 ` Colin Walters
2012-02-23 21:27 ` Pekka Enberg
2012-02-24 9:48 ` Ingo Molnar
2012-02-24 10:05 ` Pekka Enberg
2012-03-16 19:48 ` Arnaldo Carvalho de Melo [this message]
2012-03-19 18:12 ` Arnaldo Carvalho de Melo
2012-03-27 10:26 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120316194803.GQ9528@infradead.org \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).