From: Olof Johansson <olof@lixom.net>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Dmitry Artamonow <mad_soft@inbox.ru>,
Colin Cross <ccross@android.com>,
Mike Rapoport <mike@compulab.co.il>,
Thierry Reding <thierry.reding@avionic-design.de>,
linux-tegra@vger.kernel.org, Andi <andi.shyti@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/tegra: pcie: fix return value of function
Date: Sun, 18 Mar 2012 10:27:10 -0700 [thread overview]
Message-ID: <20120318172710.GA24110@quad.lixom.net> (raw)
In-Reply-To: <4F5FA1BB.5050002@wwwdotorg.org>
On Tue, Mar 13, 2012 at 01:36:27PM -0600, Stephen Warren wrote:
> On 03/12/2012 11:46 PM, Dmitry Artamonow wrote:
> > In previous patch (arm/tegra: add timeout to PCIe PLL lock detection loop)
> > tegra_pcie_enable_controller() function type has been changed from
> > void to int, but the last return statement wasn't converted, so
> > function returns undefined value. Fix it.
> >
> > Also while at it, address couple of minor concerns raised by reviewers:
> > use usleep_range for delay, and lower the value of timeout to 300ms
> > to be consistent with Nvidia Vibrante kernel.
> >
> > Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Thanks, applied to for-3.4/cleanups-and-fixes
-Olof
next prev parent reply other threads:[~2012-03-18 17:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 8:45 [PATCH/RFC 0/2] Couple of Tegra2 PCIe fixes(?) Dmitry Artamonow
2012-03-06 8:45 ` [PATCH/RFC 1/2] arm/tegra: fix harmony pinmux for PCIe Dmitry Artamonow
2012-03-06 16:55 ` Stephen Warren
2012-03-06 8:45 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Dmitry Artamonow
2012-03-06 9:38 ` Andi
2012-03-06 11:19 ` Dmitry Artamonow
2012-03-06 16:58 ` Stephen Warren
2012-03-06 19:09 ` Thierry Reding
2012-03-06 20:15 ` Dmitry Artamonow
2012-03-09 10:09 ` [PATCH v2 " Dmitry Artamonow
2012-03-12 18:09 ` Stephen Warren
2012-03-12 19:30 ` Dmitry Artamonow
2012-03-12 19:56 ` Olof Johansson
2012-03-13 5:46 ` [PATCH] arm/tegra: pcie: fix return value of function Dmitry Artamonow
2012-03-13 19:36 ` Stephen Warren
2012-03-18 17:27 ` Olof Johansson [this message]
2012-03-07 6:38 ` [PATCH/RFC 2/2] arm/tegra: add timeout to PCIe PLL lock detection loop Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120318172710.GA24110@quad.lixom.net \
--to=olof@lixom.net \
--cc=andi.shyti@gmail.com \
--cc=ccross@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=mike@compulab.co.il \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox