* linux-next: triage for March 18, 2012
@ 2012-03-18 18:41 Paul Gortmaker
2012-03-18 23:51 ` Tony Breeds
0 siblings, 1 reply; 11+ messages in thread
From: Paul Gortmaker @ 2012-03-18 18:41 UTC (permalink / raw)
To: linux-next; +Cc: linux-kernel
This represents the state of things as of Friday since I didn't
get a report out then. Four new arches have been added but none
of them yet build (top four below).
New breakage since last report:
AM33:asb2303_defconfig,asb2364_defconfig (toolchain?)
frv:defconfig (arch/frv/kernel/head.S operand out of range)
h8300:defconfig (time.c: implicit declaration 'get_irq_regs')
m32r:m32700ut.smp_defconfig (No rule to make vmlinux.bin)
m68k:allmodconfig (persistent_ram.c: implicit declaration 'memblock_reserve')
sparc[64]:allmodconfig (hda/patch_sigmatel.c: 'stac93xx_set_power_state' undeclared)
sparc/m68k:allmodconfig (implicit completion.h - already fixed)
Randconfig fails that may or may not be new (by their very nature):
i386: samsung-laptop.c: implicit declaration of 'isalnum'
(http://kisskb.ellerman.id.au/kisskb/buildresult/5884289/)
powerpc: kernel/fadump.c:407:2: error: 'crashing_cpu' undeclared
(http://kisskb.ellerman.id.au/kisskb/buildresult/5884411/)
x86_64: No rule to make scsi/aic7xxx/aicasm/*.[chyl]
http://kisskb.ellerman.id.au/kisskb/buildresult/5884287/
Builds that are fixed since last report:
ARM:orion5x_defconfig
powerpc:allmodconfig
Note: The randconfig fails are only listed once and not tracked
in the below listing.
------------------------------------------------
Latest results at:
http://kisskb.ellerman.id.au/kisskb/branch/9/
Failures as of March 18th, 2012:
===============================
AM33:asb2303_defconfig,asb2364_defconfig
when: Mar 15, 18:04
why: cc1: error: unrecognized command line option '-mmem-funcs'
status: incompatible toolchain?
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5878400/
----------------
ARM:u8500_defconfig
when: Mar 14, 08:53
why: mach-ux500/timer.c: 'IRQ_LOCALTIMER' undeclared
status: fixed
fix: http://marc.info/?l=linux-next&m=133193275811234&w=2
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884194/
ARM:mxs_defconfig
when: Mar 14, 00:19
why: Inconsistent kallsyms data This is a bug - please report
status: UFO bug keeps appearing at random
fix:
ref: https://lkml.org/lkml/2011/8/2/233
ref: https://lkml.org/lkml/2011/10/8/70
ARM:eseries_pxa_defconfig
when: Mar 14, 05:15
why: tmio_mmc_pio.c:: 'struct tmio_mmc_host' has no member named 'native_hotplug'
status: bisected and reported (PaulG).
fix: Apparently an ordering issue that should now be resolved.
ref: http://permalink.gmane.org/gmane.linux.kernel.mmc/13491
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5869552/
ARM:netx_defconfig,pnx4008_defconfig
when: Mar 14, 02:43
why: net/core/pktgen.c: can't find a register in class 'GENERAL_REGS'
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5869486/
ref: https://lkml.org/lkml/2012/3/13/670
ARM:cam60_defconfig
when: Feb 23, 16:47
why: trace_entries.h: 'perf_ftrace_event_register' undeclared
status: S. Rostedt has a patch somewhere.
fix:
ref: irc (#linux-rt)
ARM:collie_defconfig
when: Feb 14, 19:10
why: locomolcd.c: error: 'sa1100fb_lcd_power' undeclared
status: fixed (PaulG) - pending integration
fix: http://marc.info/?l=linux-next&m=133105157730749&w=2
ref:
ARM:imx_v4_v5_defconfig
when: Mar 9
why: clkdev.c: undefined reference to `vb2_dma_contig_memops'
status:
fix:
ref:
ARM:iop32x_defconfig,iop33x_defconfig
when: Nov 23, 13:42
why: restart.c: implicit declaration of function 'soft_restart'
status: fixed (PaulG) - pending integration
fix: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/081461.html
fix: https://lkml.org/lkml/2012/3/14/253
ref:
ARM:ixp4xx_defconfig
when: Oct 26, 01:40
why: gpio.h: implicit declaration of function '__gpio_get_value'
status: fixed (Imre Kaloz) - but possibly needs rework?
fix: https://lkml.org/lkml/2012/2/8/288
ref: https://lkml.org/lkml/2012/2/8/287
ARM:magician_defconfig
when: Feb 13, 19:10
why: magician.c: unknown field 'dev' specified in initializer
status: fixed (PaulG) - pending integration
fix:
ref: http://marc.info/?l=linux-next&m=133106325903524&w=2
ARM:em_x270_defconfig
when: Feb 14, 01:15
why: em-x270.c: unknown field 'dev' specified in initializer
status: fixed (PaulG) - pending integration
fix: http://www.spinics.net/lists/arm-kernel/msg164012.html
ref: http://www.spinics.net/lists/arm-kernel/msg163135.html
ARM:raumfeld_defconfig
when: Nov 23, 09:36
why: eeti_ts.c: implicit declaration of function 'irq_to_gpio'
status: perhaps broken since 2010? See ref below.
fix:
ref: http://www.gossamer-threads.com/lists/linux/kernel/1291618?do=post_view_threaded#1291618
ARM:omap2plus_defconfig
when: Feb 16, 00:23
why: control.c:238: error: 'OMAP343X_CTRL_BASE' undeclared
status: PaulG did hack-n-slash, but at best a WIP, needs additonal reverts
fix: http://www.spinics.net/lists/arm-kernel/msg163120.html
ref: http://www.spinics.net/lists/arm-kernel/msg163262.html
ARM:at91x40_defconfig
when: Feb 28, 07:38
why: super.c:(.text+0x3ffd8): undefined reference to `vm_is_stack'
status: WIP, fix from PaulG + follow on from
fix: http://marc.info/?l=linux-next&m=133096554131691&w=2
ref: http://marc.info/?l=linux-next&m=133104723928617&w=2
ARM:s3c2410_defconfig
when: Mar 7, 22:59
why: s3c244x.c: expected declaration or statement at end of input
status: bad commit introduces truncated file; pending integration.
fix:
ref: http://marc.info/?l=linux-next&m=133123680904853&w=2
ARM:arm-allnoconfig
when: forever
why: not supported
status: nothing pending, but patches accepted
fix: n/a
ref: https://lkml.org/lkml/2009/4/30/105
ref: http://lists.infradead.org/pipermail/linux-arm-kernel/2012-January/081218.html
----------------
AVR32:allnoconfig
when: May 26 2010, 20:49
why: at32_map_usart: undefined reference to `atmel_default_console_device'
status:
fix:
ref:
---------------
bfin:***all-builds***
when: Jan 20, 22:13
why: undefined reference to `vm_is_stack'
status: WIP, fix from PaulG + follow on from Siddhesh Poyarekar
fix: http://marc.info/?l=linux-next&m=133096554131691&w=2
ref: http://marc.info/?l=linux-next&m=133104723928617&w=2
---------------
cris:***all-builds***
when: Mar 25, 22:05
why: include/linux/types.h:25: error expected ... before 'ino_t'
status:
fix:
ref:
----------------
crisv32:***all-builds***
when: Mar 25, 22:05
why: include/linux/types.h:25: error expected ... before 'ino_t'
status:
fix:
ref:
----------------
frv:defconfig
when: Mar 15
why: arch/frv/kernel/head.S operand out of range
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884666/
----------------
h8300:defconfig
when: Mar 15
why: time.c: implicit declaration of function 'get_irq_regs'
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884668/
----------------
i386:allmodconfig
when: Mar 8, 20:41
why: ERROR: "pcibios_enabled" [drivers/video/uvesafb.ko] undefined!
why: ERROR: "mdfld_set_brightness" [drivers/gpu/drm/gma500/gma500_gfx.ko] undefined!
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5878506/
----------------
m32r:m32700ut.smp_defconfig
when: Mar 15
why: No rule to make target `arch/m32r/boot/compressed/vmlinux.bin
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884670/
----------------
m68k:allmodconfig
when: Mar 16
why: persistent_ram.c: implicit declaration of 'memblock_reserve'
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884324/
ref: http://www.spinics.net/lists/linux-next/msg19343.html
----------------
mips:allmodconfig
when:
why: driver_pci_host.c: implicit declaration of function 'pcibios_enable_device'
status:
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5807000/
----------------
parisc:allmodconfig
when:
why: include/linux/log2.h: implicit declaration of function 'fls'
status: reported by PaulG, WIP by David Howells
fix:
ref: https://lkml.org/lkml/2012/2/29/409
ref: https://lkml.org/lkml/2012/3/6/228
parisc64:a500_defconfig
when:
why: include/linux/log2.h: implicit declaration of function 'fls'
status: reported by PaulG, WIP by David Howells
fix:
ref: https://lkml.org/lkml/2012/2/29/409
ref: https://lkml.org/lkml/2012/3/6/228
------------------
powerpc:allyesconfig
when: May 18 2009, 22:11
why: fat ass kernel with everything simply won't link
status: need to fix build config to ignore the final link
fix:
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5806793/
powerpc:mpc885_ads_defconfig
when: Mar 8, 19:45
why: fs/nfs/inode.c:1063: undefined reference to `crc32_le'
status: solved, NFS relies on CRC32 kconfig (PaulG)
fix:
ref: http://marc.info/?l=linux-nfs&r=1&b=201203&w=2
ref:
------------------
sh4:***all-builds***
when: Feb 24, 17:38
why: include/linux/log2.h: implicit declaration of function 'fls'
status: reported by PaulG, WIP by David Howells
fix:
ref: https://lkml.org/lkml/2012/2/29/409
ref: https://lkml.org/lkml/2012/3/6/228
------------------
sparc[64]:allmodconfig
when: Mar 16, 09:21
why: patch_sigmatel.c: error: 'stac92xx_set_power_state' undeclared
status: reported
fix:
ref: http://marc.info/?l=linux-next&m=133209522419563&w=2
------------------
sparc/m68k:allmodconfig
when: Mar 14, 09:21
why: linux/mmc/core.h: field 'completion' has incomplete type
status: fixed Mar16th.
fix: http://marc.info/?l=linux-next&m=133190925501052&w=2
ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5869834/
------------------
um:um-defconfig
when: Sep 16 2010, 01:28
why: os-Linux/start_up.c: error: 'PTRACE_SETOPTIONS' undeclared
status: clearly broken forever, so does anyone care?
fix:
ref: http://kisskb.ellerman.id.au/kisskb/target/2979/
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: triage for March 18, 2012
2012-03-18 18:41 linux-next: triage for March 18, 2012 Paul Gortmaker
@ 2012-03-18 23:51 ` Tony Breeds
2012-03-19 14:51 ` Paul Gortmaker
2012-03-19 15:03 ` David Howells
0 siblings, 2 replies; 11+ messages in thread
From: Tony Breeds @ 2012-03-18 23:51 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-next, linux-kernel, David Howells
[-- Attachment #1: Type: text/plain, Size: 3648 bytes --]
On Sun, Mar 18, 2012 at 02:41:05PM -0400, Paul Gortmaker wrote:
> This represents the state of things as of Friday since I didn't
> get a report out then. Four new arches have been added but none
> of them yet build (top four below).
>
> New breakage since last report:
> AM33:asb2303_defconfig,asb2364_defconfig (toolchain?)
> frv:defconfig (arch/frv/kernel/head.S operand out of range)
> h8300:defconfig (time.c: implicit declaration 'get_irq_regs')
> m32r:m32700ut.smp_defconfig (No rule to make vmlinux.bin)
> m68k:allmodconfig (persistent_ram.c: implicit declaration 'memblock_reserve')
> sparc[64]:allmodconfig (hda/patch_sigmatel.c: 'stac93xx_set_power_state' undeclared)
> sparc/m68k:allmodconfig (implicit completion.h - already fixed)
>
> Randconfig fails that may or may not be new (by their very nature):
> i386: samsung-laptop.c: implicit declaration of 'isalnum'
> (http://kisskb.ellerman.id.au/kisskb/buildresult/5884289/)
> powerpc: kernel/fadump.c:407:2: error: 'crashing_cpu' undeclared
> (http://kisskb.ellerman.id.au/kisskb/buildresult/5884411/)
> x86_64: No rule to make scsi/aic7xxx/aicasm/*.[chyl]
> http://kisskb.ellerman.id.au/kisskb/buildresult/5884287/
>
> Builds that are fixed since last report:
> ARM:orion5x_defconfig
> powerpc:allmodconfig
>
>
> Note: The randconfig fails are only listed once and not tracked
> in the below listing.
>
> ------------------------------------------------
>
> Latest results at:
> http://kisskb.ellerman.id.au/kisskb/branch/9/
>
> Failures as of March 18th, 2012:
> ===============================
>
> AM33:asb2303_defconfig,asb2364_defconfig
> when: Mar 15, 18:04
> why: cc1: error: unrecognized command line option '-mmem-funcs'
> status: incompatible toolchain?
> fix:
> ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5878400/
> ----------------
I submitted a patch for this it hasn't been taken up yet.
http://marc.info/?l=linux-kernel&m=133185020313818&w=2
<SNIP>
> frv:defconfig
> when: Mar 15
> why: arch/frv/kernel/head.S operand out of range
> status:
> fix:
> ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884666/
> ----------------
Quite willing to accept that I have built this compiler wrong.
~$ /opt/cross/gcc-4.6.3-nolibc/frv-linux/bin/frv-linux-gcc -v
Using built-in specs.
COLLECT_GCC=/opt/cross/gcc-4.6.3-nolibc/frv-linux/bin/frv-linux-gcc
COLLECT_LTO_WRAPPER=/opt/crosstool/gcc-4.6.3-nolibc/frv-linux/bin/../libexec/gcc/frv-linux/4.6.3/lto-wrapper
Target: frv-linux
Configured with: /home/tony/buildall/src/gcc/configure --target=frv-linux --host=ppc64-linux-gnu --build=ppc64-linux-gnu --enable-targets=all --prefix=/home/tony/buildall/cross.ppc64/gcc-4.6.3-nolibc/frv-linux/ --enable-languages=c --with-newlib --without-headers --enable-sjlj-exceptions --with-system-libunwind --disable-nls --disable-threads --disable-shared --disable-libmudflap --disable-libssp --disable-libgomp --disable-decimal-float --enable-checking=release --with-mpfr=/home/tony/buildall/src/sys-ppc64 --with-gmp=/home/tony/buildall/src/sys-ppc64 --disable-bootstrap --disable-libquadmath
Thread model: single
gcc version 4.6.3 (GCC)
If there is somethign I need to chenge when building gcc let me know.
> h8300:defconfig
> when: Mar 15
> why: time.c: implicit declaration of function 'get_irq_regs'
> status:
> fix:
> ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884668/
> ----------------
Later there is also an internal compiler error reported at:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52598
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-18 23:51 ` Tony Breeds
@ 2012-03-19 14:51 ` Paul Gortmaker
2012-03-27 23:59 ` Tony Breeds
2012-03-19 15:03 ` David Howells
1 sibling, 1 reply; 11+ messages in thread
From: Paul Gortmaker @ 2012-03-19 14:51 UTC (permalink / raw)
To: linux-next, linux-kernel, David Howells
[Re: linux-next: triage for March 18, 2012] On 19/03/2012 (Mon 10:51) Tony Breeds wrote:
> On Sun, Mar 18, 2012 at 02:41:05PM -0400, Paul Gortmaker wrote:
[...]
> >
> > AM33:asb2303_defconfig,asb2364_defconfig
> > when: Mar 15, 18:04
> > why: cc1: error: unrecognized command line option '-mmem-funcs'
> > status: incompatible toolchain?
> > fix:
> > ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5878400/
> > ----------------
>
> I submitted a patch for this it hasn't been taken up yet.
> http://marc.info/?l=linux-kernel&m=133185020313818&w=2
> <SNIP>
>
> > frv:defconfig
> > when: Mar 15
> > why: arch/frv/kernel/head.S operand out of range
> > status:
> > fix:
> > ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884666/
> > ----------------
>
> Quite willing to accept that I have built this compiler wrong.
>
> ~$ /opt/cross/gcc-4.6.3-nolibc/frv-linux/bin/frv-linux-gcc -v
> Using built-in specs.
> COLLECT_GCC=/opt/cross/gcc-4.6.3-nolibc/frv-linux/bin/frv-linux-gcc
> COLLECT_LTO_WRAPPER=/opt/crosstool/gcc-4.6.3-nolibc/frv-linux/bin/../libexec/gcc/frv-linux/4.6.3/lto-wrapper
> Target: frv-linux
> Configured with: /home/tony/buildall/src/gcc/configure --target=frv-linux --host=ppc64-linux-gnu --build=ppc64-linux-gnu --enable-targets=all --prefix=/home/tony/buildall/cross.ppc64/gcc-4.6.3-nolibc/frv-linux/ --enable-languages=c --with-newlib --without-headers --enable-sjlj-exceptions --with-system-libunwind --disable-nls --disable-threads --disable-shared --disable-libmudflap --disable-libssp --disable-libgomp --disable-decimal-float --enable-checking=release --with-mpfr=/home/tony/buildall/src/sys-ppc64 --with-gmp=/home/tony/buildall/src/sys-ppc64 --disable-bootstrap --disable-libquadmath
> Thread model: single
> gcc version 4.6.3 (GCC)
>
> If there is somethign I need to chenge when building gcc let me know.
>
> > h8300:defconfig
> > when: Mar 15
> > why: time.c: implicit declaration of function 'get_irq_regs'
> > status:
> > fix:
> > ref: http://kisskb.ellerman.id.au/kisskb/buildresult/5884668/
> > ----------------
>
> Later there is also an internal compiler error reported at:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52598
Thanks for the updates. I've added the am33 and h8300 info. I don't
know what to advise wrt. the frv platform... there doesn't even appear
to be an x86_64 cross that I can steal to try and reproduce it with.
( http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.0/ )
Paul.
>
> Yours Tony
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-19 14:51 ` Paul Gortmaker
@ 2012-03-27 23:59 ` Tony Breeds
2012-03-28 0:08 ` Paul Gortmaker
0 siblings, 1 reply; 11+ messages in thread
From: Tony Breeds @ 2012-03-27 23:59 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-next, linux-kernel, David Howells
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Mon, Mar 19, 2012 at 10:51:25AM -0400, Paul Gortmaker wrote:
> Thanks for the updates. I've added the am33 and h8300 info. I don't
> know what to advise wrt. the frv platform... there doesn't even appear
> to be an x86_64 cross that I can steal to try and reproduce it with.
> ( http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.0/ )
Look again now: http://kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-27 23:59 ` Tony Breeds
@ 2012-03-28 0:08 ` Paul Gortmaker
0 siblings, 0 replies; 11+ messages in thread
From: Paul Gortmaker @ 2012-03-28 0:08 UTC (permalink / raw)
To: Paul Gortmaker, linux-next, linux-kernel, David Howells
On Tue, Mar 27, 2012 at 7:59 PM, Tony Breeds <tony@bakeyournoodle.com> wrote:
> On Mon, Mar 19, 2012 at 10:51:25AM -0400, Paul Gortmaker wrote:
>
>> Thanks for the updates. I've added the am33 and h8300 info. I don't
>> know what to advise wrt. the frv platform... there doesn't even appear
>> to be an x86_64 cross that I can steal to try and reproduce it with.
>> ( http://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.0/ )
>
> Look again now: http://kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/
Cool. I'll give that a spin tomorrow and see what happens.
P.
>
> Yours Tony
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-18 23:51 ` Tony Breeds
2012-03-19 14:51 ` Paul Gortmaker
@ 2012-03-19 15:03 ` David Howells
2012-03-19 15:21 ` David Howells
2012-03-19 22:20 ` Tony Breeds
1 sibling, 2 replies; 11+ messages in thread
From: David Howells @ 2012-03-19 15:03 UTC (permalink / raw)
To: Tony Breeds; +Cc: dhowells, Paul Gortmaker, linux-next, linux-kernel
Tony Breeds <tony@bakeyournoodle.com> wrote:
> > frv:defconfig (arch/frv/kernel/head.S operand out of range)
What binutils are you using? I suspect this is fixed by a patch that only
went upstream very recently. Are you using a 64-bit machine to do your
compilation?
David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-19 15:03 ` David Howells
@ 2012-03-19 15:21 ` David Howells
2012-03-19 17:23 ` Valdis.Kletnieks
2012-03-19 22:20 ` Tony Breeds
1 sibling, 1 reply; 11+ messages in thread
From: David Howells @ 2012-03-19 15:21 UTC (permalink / raw)
To: Tony Breeds; +Cc: dhowells, Paul Gortmaker, linux-next, linux-kernel
David Howells <dhowells@redhat.com> wrote:
> Tony Breeds <tony@bakeyournoodle.com> wrote:
>
> > > frv:defconfig (arch/frv/kernel/head.S operand out of range)
>
> What binutils are you using? I suspect this is fixed by a patch that only
> went upstream very recently. Are you using a 64-bit machine to do your
> compilation?
Here's a patch I got from Nick Clifton to fix 64-bit binutils to handle
representing things like 0xfffffff1 as a 32-bit negative immediate argument.
It has been applied upstream.
David
---
Index: opcodes/cgen-asm.c
===================================================================
RCS file: /cvs/src/src/opcodes/cgen-asm.c,v
retrieving revision 1.14
diff -c -3 -p -r1.14 cgen-asm.c
*** opcodes/cgen-asm.c 2 Sep 2009 07:20:29 -0000 1.14
--- opcodes/cgen-asm.c 15 Dec 2011 08:27:02 -0000
*************** cgen_parse_signed_integer (CGEN_CPU_DESC
*** 268,274 ****
&result, &value);
/* FIXME: Examine `result'. */
if (!errmsg)
! *valuep = value;
return errmsg;
}
--- 268,291 ----
&result, &value);
/* FIXME: Examine `result'. */
if (!errmsg)
! {
! #if 1
! /* Handle the case where a hex value is parsed on a 64-bit host.
! A value like 0xffffe000 is clearly intended to be a negative
! 16-bit value, but on a 64-bit host it will be parsed by gas
! as 0x00000000ffffe000.
!
! The shifts below are designed not to produce compile time
! warnings when compiled on a 32-bit host. */
! if (sizeof (value) > 4
! && result == CGEN_PARSE_OPERAND_RESULT_NUMBER
! && value > 0
! && (value & 0x80000000)
! && ((value >> 31) == 1))
! value |= -1 << 31;
! #endif
! *valuep = value;
! }
return errmsg;
}
Index: opcodes/frv-asm.c
===================================================================
RCS file: /cvs/src/src/opcodes/frv-asm.c,v
retrieving revision 1.19
diff -c -3 -p -r1.19 frv-asm.c
*** opcodes/frv-asm.c 27 Jun 2010 04:07:55 -0000 1.19
--- opcodes/frv-asm.c 15 Dec 2011 08:27:02 -0000
*************** parse_uhi16 (CGEN_CPU_DESC cd,
*** 465,475 ****
if (errmsg == NULL
&& result_type == CGEN_PARSE_OPERAND_RESULT_NUMBER)
{
! /* If bfd_vma is wider than 32 bits, but we have a sign-
! or zero-extension, truncate it. */
! if (value >= - ((bfd_vma)1 << 31)
! || value <= ((bfd_vma)1 << 31) - (bfd_vma)1)
value &= (((bfd_vma)1 << 16) << 16) - 1;
value >>= 16;
}
*valuep = value;
--- 465,475 ----
if (errmsg == NULL
&& result_type == CGEN_PARSE_OPERAND_RESULT_NUMBER)
{
! /* If value is wider than 32 bits then be
! careful about how we extract bits 16-31. */
! if (sizeof (value) > 4)
value &= (((bfd_vma)1 << 16) << 16) - 1;
+
value >>= 16;
}
*valuep = value;
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: linux-next: triage for March 18, 2012
2012-03-19 15:21 ` David Howells
@ 2012-03-19 17:23 ` Valdis.Kletnieks
2012-03-19 19:41 ` David Howells
0 siblings, 1 reply; 11+ messages in thread
From: Valdis.Kletnieks @ 2012-03-19 17:23 UTC (permalink / raw)
To: David Howells; +Cc: Tony Breeds, Paul Gortmaker, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Mon, 19 Mar 2012 15:21:31 -0000, David Howells said:
> Here's a patch I got from Nick Clifton to fix 64-bit binutils to handle
> representing things like 0xfffffff1 as a 32-bit negative immediate argument.
> It has been applied upstream.
> ! #if 1
> ! /* Handle the case where a hex value is parsed on a 64-bit host.
> ! A value like 0xffffe000 is clearly intended to be a negative
> ! 16-bit value, but on a 64-bit host it will be parsed by gas
> ! as 0x00000000ffffe000.
Umm.. it's not clear to *me* that it's intended to be a negative 16 bit? Or am I just
missing context not present in the patch?
(I have no idea if the rest of the patch is OK or not, but that comment didn't give
me warm fuzzies....)
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-19 17:23 ` Valdis.Kletnieks
@ 2012-03-19 19:41 ` David Howells
2012-03-19 21:56 ` Valdis.Kletnieks
0 siblings, 1 reply; 11+ messages in thread
From: David Howells @ 2012-03-19 19:41 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: dhowells, Tony Breeds, Paul Gortmaker, linux-next, linux-kernel
Valdis.Kletnieks@vt.edu wrote:
> Umm.. it's not clear to *me* that it's intended to be a negative 16 bit? Or
> am I just missing context not present in the patch?
>
> (I have no idea if the rest of the patch is OK or not, but that comment
> didn't give me warm fuzzies....)
Sorry, I haven't explained it well.
The patch permits a 64-bit hosted assembler to represent a large 32-bit
unsigned integer (such as 0xfffffff1) as a negative integer where the
instruction being assembled has a signed immediate operand.
For instance, the ANDI instruction on FRV takes a small signed integer (10
bits IIRC) that it sign-extends to 32-bits before using - so to clear a single
low-order bit, I pass in, say, ~0x2 and the assembler represents this as a
negative value.
The problem was that in a 64-bit hosted assembler, the unsigned 32-bit integer
gets converted to an unsigned 64-bit integer - which doesn't then appear
negative (whereas in a 32-bit hosted assembler it does).
David
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-19 19:41 ` David Howells
@ 2012-03-19 21:56 ` Valdis.Kletnieks
0 siblings, 0 replies; 11+ messages in thread
From: Valdis.Kletnieks @ 2012-03-19 21:56 UTC (permalink / raw)
To: David Howells; +Cc: Tony Breeds, Paul Gortmaker, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Mon, 19 Mar 2012 19:41:44 -0000, David Howells said:
> Valdis.Kletnieks@vt.edu wrote:
>
> > Umm.. it's not clear to *me* that it's intended to be a negative 16 bit? Or
> > am I just missing context not present in the patch?
> >
> > (I have no idea if the rest of the patch is OK or not, but that comment
> > didn't give me warm fuzzies....)
> The patch permits a 64-bit hosted assembler to represent a large 32-bit
> unsigned integer (such as 0xfffffff1) as a negative integer where the
> instruction being assembled has a signed immediate operand.
Oh, I understood the gist of the patch. My question was specifically
regarding the comment saying:
"0xffffe000 is clearly intended to be a negative 16-bit value"
I'd guess it was a negative *32* bit value, unless there's context constraining it to 16....
[-- Attachment #2: Type: application/pgp-signature, Size: 865 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: linux-next: triage for March 18, 2012
2012-03-19 15:03 ` David Howells
2012-03-19 15:21 ` David Howells
@ 2012-03-19 22:20 ` Tony Breeds
1 sibling, 0 replies; 11+ messages in thread
From: Tony Breeds @ 2012-03-19 22:20 UTC (permalink / raw)
To: David Howells; +Cc: Paul Gortmaker, linux-next, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Mon, Mar 19, 2012 at 03:03:57PM +0000, David Howells wrote:
> Tony Breeds <tony@bakeyournoodle.com> wrote:
>
> > > frv:defconfig (arch/frv/kernel/head.S operand out of range)
>
> What binutils are you using? I suspect this is fixed by a patch that only
> went upstream very recently. Are you using a 64-bit machine to do your
> compilation?
I'm using binutils 2.22 on a 64-bit machine. So the patch you supplied
probably wasn't applied. I'll rebuilf the frv toolchain with that patch
today.
Thanks David.
Yours Tony
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2012-03-28 0:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-18 18:41 linux-next: triage for March 18, 2012 Paul Gortmaker
2012-03-18 23:51 ` Tony Breeds
2012-03-19 14:51 ` Paul Gortmaker
2012-03-27 23:59 ` Tony Breeds
2012-03-28 0:08 ` Paul Gortmaker
2012-03-19 15:03 ` David Howells
2012-03-19 15:21 ` David Howells
2012-03-19 17:23 ` Valdis.Kletnieks
2012-03-19 19:41 ` David Howells
2012-03-19 21:56 ` Valdis.Kletnieks
2012-03-19 22:20 ` Tony Breeds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox