From: Jonathan Nieder <jrnieder@gmail.com>
To: Santiago Garcia Mantinan <manty@debian.org>
Cc: linux-kernel@vger.kernel.org,
Matthias Urlichs <smurf@smurf.noris.de>,
linux-usb@vger.kernel.org,
Dirk De Schepper <ddeschepper@nvtl.com>
Subject: Re: [PATCH] USB: option: re-add NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED to option_id array
Date: Mon, 19 Mar 2012 10:08:01 -0500 [thread overview]
Message-ID: <20120319150801.GC11180@burratino> (raw)
In-Reply-To: <20120319102154.GA16536@www.manty.net>
(cc-ing some relevant people)
Hi,
Santiago Garcia Mantinan wrote:
> c7aa8f44b4d1dc73591894a2dd6909213612d299
[...]
> removed NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED from the scruct while
> moving things around, it was a bit difficult to see as the defines and the
> struct are not on the same order. We've carried this for a year and a half
> and for what I've seen there have been some reports about this like:
> https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/750362
> but unfortunately it didn't get much attention.
>
> I've looked at the strings and the only one missing was
> NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED, so here is the patch for it.
Thanks! Can we have your sign-off? See Documentation/SubmittingPatches,
item 12 "Sign your work", for what this means.
> --- option.c.old 2012-03-19 10:16:31.046565765 +0100
> +++ option.c 2012-03-19 10:55:34.348846327 +0100
> @@ -538,6 +538,7 @@
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_EMBEDDED_FULLSPEED) },
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_EMBEDDED_FULLSPEED) },
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_HIGHSPEED) },
> + { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED) },
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED3) },
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED4) },
> { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED5) },
Hope that helps,
Jonathan
next prev parent reply other threads:[~2012-03-19 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 10:21 readd back NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED to option.c [patch] Santiago Garcia Mantinan
2012-03-19 15:08 ` Jonathan Nieder [this message]
2012-03-19 17:17 ` [PATCH] USB: option: re-add NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED to option_id array Santiago Garcia Mantinan
2012-03-19 18:25 ` [RFC/PATCH] USB: option: handle Novatel 3G modem 1410:7001 out of the box again Jonathan Nieder
2012-03-19 18:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319150801.GC11180@burratino \
--to=jrnieder@gmail.com \
--cc=ddeschepper@nvtl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manty@debian.org \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox