Re: [PATCH] ARM: iop: add missing includes

Re: [PATCH] ARM: iop: add missing includes

[Aaro Koskinen]

Hi,

On Wed, Feb 15, 2012 at 02:24:42PM -0800, Olof Johansson wrote:
> Resolves two build breaks. One is a boatload of "unknown type name 'u32'"
> in iop3xx.h due to missing include of <linux/types.h>.
> 
> The other is:
> arch/arm/plat-iop/restart.c: In function 'iop3xx_restart':
> arch/arm/plat-iop/restart.c:18:2: error: implicit declaration of function 'soft_restart' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>

Any chance to get this patch into 3.3.1 (stable), when and if such is made?

The v3.3 fails to build for IOP boards without this.

> ---
> 
>  arch/arm/include/asm/hardware/iop3xx.h |    2 ++
>  arch/arm/plat-iop/restart.c            |    1 +
>  2 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/hardware/iop3xx.h b/arch/arm/include/asm/hardware/iop3xx.h
> index 077c323..ec0224d 100644
> --- a/arch/arm/include/asm/hardware/iop3xx.h
> +++ b/arch/arm/include/asm/hardware/iop3xx.h
> @@ -15,6 +15,8 @@
>  #ifndef __IOP3XX_H
>  #define __IOP3XX_H
>  
> +#include <linux/types.h>
> +
>  /*
>   * IOP3XX GPIO handling
>   */
> diff --git a/arch/arm/plat-iop/restart.c b/arch/arm/plat-iop/restart.c
> index 6a85a0c..a6ee3b6 100644
> --- a/arch/arm/plat-iop/restart.c
> +++ b/arch/arm/plat-iop/restart.c
> @@ -8,6 +8,7 @@
>   * published by the Free Software Foundation.
>   */
>  #include <asm/hardware/iop3xx.h>
> +#include <asm/system.h>
>  #include <mach/hardware.h>
>  
>  void iop3xx_restart(char mode, const char *cmd)
> -- 
> 1.7.9.209.gb6b3b

A.

Re: [PATCH] ARM: iop: add missing includes

[Greg KH]

On Mon, Mar 19, 2012 at 09:40:16PM +0200, Aaro Koskinen wrote:
> Hi,
> 
> On Wed, Feb 15, 2012 at 02:24:42PM -0800, Olof Johansson wrote:
> > Resolves two build breaks. One is a boatload of "unknown type name 'u32'"
> > in iop3xx.h due to missing include of <linux/types.h>.
> > 
> > The other is:
> > arch/arm/plat-iop/restart.c: In function 'iop3xx_restart':
> > arch/arm/plat-iop/restart.c:18:2: error: implicit declaration of function 'soft_restart' [-Werror=implicit-function-declaration]
> > 
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> 
> Any chance to get this patch into 3.3.1 (stable), when and if such is made?
> 
> The v3.3 fails to build for IOP boards without this.

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>