From: Arnd Bergmann <arnd@arndb.de>
To: Roland Stigge <stigge@antcom.de>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
w.sang@pengutronix.de, kevin.wells@nxp.com,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
srinivas.bakki@nxp.com
Subject: Re: [PATCH] USB: gadget driver for LPC32xx
Date: Mon, 19 Mar 2012 21:30:13 +0000 [thread overview]
Message-ID: <201203192130.13583.arnd@arndb.de> (raw)
In-Reply-To: <1332191930-2433-1-git-send-email-stigge@antcom.de>
On Monday 19 March 2012, Roland Stigge wrote:
> This patch adds a USB gadget driver.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
> ---
>
> Applies to v3.3
>
>
> drivers/usb/gadget/Kconfig | 10
> drivers/usb/gadget/Makefile | 1
> drivers/usb/gadget/gadget_chips.h | 3
> drivers/usb/gadget/lpc32xx_udc.c | 3598 ++++++++++++++++++++++++++++++++++++++
> 4 files changed, 3612 insertions(+)
Hi Roland,
There is already a driver for the isp1301 otg part in the kernel, I don't
think we want to add another one.
>From what I can tell, this shares a common ancestry with the omap version
but has diverged quite a bit. The best solution would really be to
bring the two back together and let them share a common base driver,
with the lpc32xx and omap specific bits in another file.
Arnd
next prev parent reply other threads:[~2012-03-19 21:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 21:18 [PATCH] USB: gadget driver for LPC32xx Roland Stigge
2012-03-19 21:30 ` Arnd Bergmann [this message]
2012-03-19 22:26 ` Roland Stigge
2012-03-20 13:01 ` Arnd Bergmann
2012-03-20 18:20 ` Roland Stigge
2012-03-20 19:21 ` Arnd Bergmann
2012-03-20 1:56 ` Alan Stern
2012-03-23 8:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203192130.13583.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=arm@kernel.org \
--cc=kevin.wells@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srinivas.bakki@nxp.com \
--cc=stigge@antcom.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox