From: Jozef Vesely <vesely@gjh.sk>
To: linux-kernel@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com
Subject: possible bug (or not clear coding) in uvc_v4l2.c
Date: Tue, 20 Mar 2012 17:02:51 +0100 [thread overview]
Message-ID: <20120320160251.GA79846@mail.kolej.mff.cuni.cz> (raw)
Good day,
I am sorry to disturb you, I have been reading through uvc driver source
and this caught my eye:
http://lxr.linux.no/#linux+v3.3/drivers/media/video/uvc/uvc_v4l2.c#L671
678: int pin = 0;
...
689: } else if (pin < selector->bNrInPins) {
...
690: pin = selector->baSourceID[index];
pin is always 0 in the comparison, was this intended?
(wasn't the line 690 supposed to be before the comparison?
or the index to be compared to bNrInPins?)
Please excuse me wasting your tine if it is a total nonsense.
Sincerely
Jozef Vesely
vesely@gjh.sk
PS: I am looking for a reason why MJPEG stopped working
on my cameras (long time ago), any hints?
next reply other threads:[~2012-03-20 16:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 16:02 Jozef Vesely [this message]
2012-03-21 12:58 ` possible bug (or not clear coding) in uvc_v4l2.c Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320160251.GA79846@mail.kolej.mff.cuni.cz \
--to=vesely@gjh.sk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).